From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v4][PATCH 14/19] tools/libxl: detect and avoid conflicts with RDM Date: Mon, 29 Jun 2015 14:36:25 +0800 Message-ID: <5590E769.5070709@intel.com> References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com> <1435053450-25131-15-git-send-email-tiejun.chen@intel.com> <20150625112352.GJ6545@zion.uk.xensource.com> <558CE6DE.8010204@intel.com> <20150626121349.GC1609@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150626121349.GC1609@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Stefano Stabellini , Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >> static int >> libxl__xc_device_get_rdm(libxl__gc *gc, >> uint32_t flag, >> uint16_t seg, >> uint8_t bus, >> uint8_t devfn, >> unsigned int *nr_entries, >> struct xen_reserved_device_memory *xrdm) > > Shouldn't this be struct xen_reserved_device_memory **xrdm? That is, You're right, please review this next revision. Thanks Tiejun