All of lore.kernel.org
 help / color / mirror / Atom feed
From: wangyf <wangyf-fnst@cn.fujitsu.com>
To: Omar Sandoval <osandov@fb.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] btrfs: add a test of replace missing dev in diff raid
Date: Mon, 29 Jun 2015 17:13:38 +0800	[thread overview]
Message-ID: <55910C42.7030707@cn.fujitsu.com> (raw)
In-Reply-To: <20150626222409.GA27386@huxley.DHCP.TheFacebook.com>

Hello, Omar:

To update some cases to support RAID5/6 is necessary.
Like btrfs/011 btrfs/071 , and the man page of BTRFS-REPLACE,
they all should be modified.

But equipment damage and missing device is small probability event when
we use disks in our daily life. So it shouldn't be so important that we let
_btrfs_get_profile_confilgs know it.
Besides, every case tests a different direction of replace is good. e.g.
011 071  020 etc.

So I think to test it in a new case is better.  What is your opinion?

cheers,
wangyf


On 06/27/2015 06:24 AM, Omar Sandoval wrote:
> On Fri, Jun 26, 2015 at 01:21:03PM +0800, Wang Yanfeng wrote:
> [snip]
>> +_test "raid1"
>> +_test "raid10"
>> +_test "raid5"
>> +_test "raid6"
> Hi, Wang Yanfeng,
>
> Thanks a lot for posting this. This looks similar to the stuff in, e.g.,
> btrfs/071:
>
> 	_btrfs_get_profile_configs replace
> 	...
> 	echo "Silence is golden"
> 	for t in "${_btrfs_profile_configs[@]}"; do
> 		run_test "$t"
> 	done
>
> It'd be nice to do it the same way in this test. _btrfs_profile_configs
> would need to be updated to support RAID 5/6 and be aware of replace
> missing. I'll attach a patch, feel free to use it. Additionally, we
> could also update btrfs/011 to test RAID 5/6.
>
> Thanks,


  reply	other threads:[~2015-06-29  9:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26  5:21 [PATCH] btrfs: add a test of replace missing dev in diff raid Wang Yanfeng
2015-06-26 22:24 ` Omar Sandoval
2015-06-29  9:13   ` wangyf [this message]
2015-06-29 18:06     ` Omar Sandoval
2015-06-30  1:51       ` wangyf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55910C42.7030707@cn.fujitsu.com \
    --to=wangyf-fnst@cn.fujitsu.com \
    --cc=fstests@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.