From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752985AbbF2LUE (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Jun 2015 07:20:04 -0400
Received: from mga01.intel.com ([192.55.52.88]:41845 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752641AbbF2LT7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Jun 2015 07:19:59 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,698,1427785200"; 
   d="scan'208";a="719526150"
Message-ID: <5591293E.80308@intel.com>
Date: Mon, 29 Jun 2015 14:17:18 +0300
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki 
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Kan Liang <kan.liang@intel.com>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH perf/core] perf tools: Add missing break for PERF_RECORD_ITRACE_START
References: <1435576340-19346-1-git-send-email-jolsa@kernel.org>
In-Reply-To: <1435576340-19346-1-git-send-email-jolsa@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 29/06/15 14:12, Jiri Olsa wrote:
> Missing switch break since introduction of new event:
>   c4937a91ea56 perf tools: handle PERF_RECORD_LOST_SAMPLES
> 
> Cc: Kan Liang <kan.liang@intel.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Link: http://lkml.kernel.org/n/tip-e3gbrp2561x2s9tkqvf2wh9n@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/util/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index 4744673aff1b..a08e38339cac 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -1448,7 +1448,7 @@ int machine__process_event(struct machine *machine, union perf_event *event,
>  	case PERF_RECORD_AUX:
>  		ret = machine__process_aux_event(machine, event); break;
>  	case PERF_RECORD_ITRACE_START:
> -		ret = machine__process_itrace_start_event(machine, event);
> +		ret = machine__process_itrace_start_event(machine, event); break;
>  	case PERF_RECORD_LOST_SAMPLES:
>  		ret = machine__process_lost_samples_event(machine, event, sample); break;
>  		break;

But now you have break; break;

Isn't putting 'break' on the end of the line making things harder to read?