From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 4/7] xen: get rid of the SEDF scheduler
Date: Mon, 29 Jun 2015 12:56:07 +0100
Message-ID: <55913257.2040300@citrix.com>
References: <20150626161417.29181.992.stgit@Solace.station>
	<20150626161913.29181.50416.stgit@Solace.station>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6154dc4e6=Andrew.Cooper3@citrix.com>)
	id 1Z9Xfr-0002PM-Ma
	for xen-devel@lists.xenproject.org; Mon, 29 Jun 2015 11:56:31 +0000
In-Reply-To: <20150626161913.29181.50416.stgit@Solace.station>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 26/06/15 17:19, Dario Faggioli wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -324,7 +324,6 @@ DEFINE_XEN_GUEST_HANDLE(xen_domctl_max_vcpus_t);
>  
>  /* XEN_DOMCTL_scheduler_op */
>  /* Scheduler types. */
> -#define XEN_SCHEDULER_SEDF     4

Please instead use:

/* #define XEN_SCHEDULER_SEDF     4 (Removed) */

To help keep bits of the history, and reduce the likelyhood of
accidental reuse.

>  #define XEN_SCHEDULER_CREDIT   5
>  #define XEN_SCHEDULER_CREDIT2  6
>  #define XEN_SCHEDULER_ARINC653 7
> @@ -337,13 +336,6 @@ struct xen_domctl_scheduler_op {
>      uint32_t sched_id;  /* XEN_SCHEDULER_* */
>      uint32_t cmd;       /* XEN_DOMCTL_SCHEDOP_* */
>      union {
> -        struct xen_domctl_sched_sedf {
> -            uint64_aligned_t period;
> -            uint64_aligned_t slice;
> -            uint64_aligned_t latency;
> -            uint32_t extratime;
> -            uint32_t weight;
> -        } sedf;
>          struct xen_domctl_sched_credit {
>              uint16_t weight;
>              uint16_t cap;
> diff --git a/xen/include/public/trace.h b/xen/include/public/trace.h
> index 5211ae7..36be196 100644
> --- a/xen/include/public/trace.h
> +++ b/xen/include/public/trace.h
> @@ -75,7 +75,6 @@
>  /* Per-scheduler IDs, to identify scheduler specific events */
>  #define TRC_SCHED_CSCHED   0
>  #define TRC_SCHED_CSCHED2  1
> -#define TRC_SCHED_SEDF     2

Same here.

~Andrew

>  #define TRC_SCHED_ARINC653 3
>  #define TRC_SCHED_RTDS     4
>  
> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
> index 7cc25c6..dbe7cab 100644
> --- a/xen/include/xen/sched-if.h
> +++ b/xen/include/xen/sched-if.h
> @@ -165,7 +165,6 @@ struct scheduler {
>      void         (*tick_resume)     (const struct scheduler *, unsigned int);
>  };
>  
> -extern const struct scheduler sched_sedf_def;
>  extern const struct scheduler sched_credit_def;
>  extern const struct scheduler sched_credit2_def;
>  extern const struct scheduler sched_arinc653_def;
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel