From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 0/3] KVM: arm: Implement software vGICv2 emulation
Date: Mon, 29 Jun 2015 13:13:00 +0100
Message-ID: <5591364C.2020204@arm.com>
References: <cover.1435567226.git.p.fedin@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Christoffer Dall <christoffer.dall@linaro.org>,
	Andre Przywara <andre.przywara@arm.com>
To: Pavel Fedin <p.fedin@samsung.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from foss.arm.com ([217.140.101.70]:37761 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752098AbbF2MND (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 29 Jun 2015 08:13:03 -0400
In-Reply-To: <cover.1435567226.git.p.fedin@samsung.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Pavel,

On 29/06/15 10:53, Pavel Fedin wrote:
> Some hardware (like Raspberry Pi 2) is capable of running KVM, however lacks
> functional vGIC registers. This series introduces software vGIC emulation for
> such machines, allowing to fully use virtualization capabilities

I'm really not keen on any of this. The RPi-2 is mostly unsupported in
mainline, and not only lacks the vGIC, but doesn't have a GIC at all.
This would break ongoing developments (inability to properly support
EOImode=1, to preserve the active state for shared devices like timers).

As far as I'm concerned, this hardware is not architecturally compliant
and the solution is to use userspace emulation (QEMU provides a GIC
model). Taking these patches would keep us stuck in the past.

I'm sure whoever maintains the RPi kernel will be glad to take these
patches on top of the pile of stuff they keep out of tree.

Thanks,

	M.

> Pavel Fedin (3):
>   KVM: arm: Add basic infrastructure for software vGIC emulation
>   KVM: arm: Introduce software emulation of vGICv2 CPU interface
>   KVM: arm: Enable vGICv2 software emulation
> 
>  include/kvm/arm_vgic.h      |   4 ++
>  virt/kvm/arm/vgic-v2-emul.c |  60 +++++++++++++++--
>  virt/kvm/arm/vgic-v2.c      |  29 ++++----
>  virt/kvm/arm/vgic.c         | 159 +++++++++++++++++++++++++++++++++-----------
>  virt/kvm/arm/vgic.h         |   3 +
>  5 files changed, 196 insertions(+), 59 deletions(-)
> 


-- 
Jazz is not dead. It just smells funny...