From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-gpio@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Axel Lin <axel.lin@ingics.com>, Andrew Lunn <andrew@lunn.ch>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpio: mvebu: kill bogus dependency on GPIO_GENERIC
Date: Mon, 29 Jun 2015 14:25:53 +0200 [thread overview]
Message-ID: <55913951.2020401@free-electrons.com> (raw)
In-Reply-To: <CAK7LNAR_uGLtGYt0ioOwbOA=iAH1dOE4q+TQ2yRuMqf5P242Yg@mail.gmail.com>
Hi Masahiro,
On 21/06/2015 01:54, Masahiro Yamada wrote:
> Adding more people.
>
> I'd like them to check if this patch is correct.
>
>
> 2015-06-19 20:31 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
>> Drop unneeded "select GPIO_GENERIC".
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
This would have come from a wrong copy and paste, because indeed we
have never used the gpio-generic.
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
>> ---
>>
>> drivers/gpio/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 25c232e..241d441 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -283,7 +283,6 @@ config GPIO_MVEBU
>> def_bool y
>> depends on PLAT_ORION
>> depends on OF
>> - select GPIO_GENERIC
>> select GENERIC_IRQ_CHIP
>>
>> config GPIO_MXC
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-06-29 12:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 11:31 [PATCH 1/2] gpio: altera: kill bogus dependency on GPIO_GENERIC Masahiro Yamada
2015-06-19 11:31 ` Masahiro Yamada
2015-06-19 11:31 ` [PATCH 2/2] gpio: mvebu: " Masahiro Yamada
2015-06-19 11:31 ` Masahiro Yamada
2015-06-20 23:54 ` Masahiro Yamada
2015-06-20 23:54 ` Masahiro Yamada
2015-06-29 12:25 ` Gregory CLEMENT [this message]
2015-07-15 9:47 ` Linus Walleij
2015-06-20 23:48 ` [PATCH 1/2] gpio: altera: " Masahiro Yamada
2015-06-20 23:48 ` Masahiro Yamada
2015-06-26 3:15 ` Tien Hock Loh
2015-06-26 3:15 ` Tien Hock Loh
2015-07-15 8:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55913951.2020401@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=axel.lin@ingics.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.