From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 04/12] x86/altp2m: basic data structures
 and support routines.
Date: Mon, 29 Jun 2015 14:00:58 +0100
Message-ID: <5591418A.9030804@citrix.com>
References: <1434999372-3688-1-git-send-email-edmund.h.white@intel.com>
	<1434999372-3688-5-git-send-email-edmund.h.white@intel.com>
	<558A8689.2060501@citrix.com> <558DC177.3020004@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <558DC177.3020004@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ed White <edmund.h.white@intel.com>, xen-devel@lists.xen.org
Cc: Ravi Sahita <ravi.sahita@intel.com>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com>, tlengyel@novetta.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

On 26/06/15 22:17, Ed White wrote:
> On 06/24/2015 03:29 AM, Andrew Cooper wrote:
>> On 22/06/15 19:56, Ed White wrote:
>>> diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/asm-x86/hvm/vcpu.h
>>> index 3d8f4dc..a1529c0 100644
>>> --- a/xen/include/asm-x86/hvm/vcpu.h
>>> +++ b/xen/include/asm-x86/hvm/vcpu.h
>>> @@ -118,6 +118,13 @@ struct nestedvcpu {
>>>  
>>>  #define vcpu_nestedhvm(v) ((v)->arch.hvm_vcpu.nvcpu)
>>>  
>>> +struct altp2mvcpu {
>>> +    uint16_t    p2midx;         /* alternate p2m index */
>>> +    uint64_t    veinfo_gfn;     /* #VE information page guest pfn */
>> Please use the recently-introduced pfn_t here.  pfn is a more
>> appropriate term than gfn in this case.
> Did you mean pfn_t, or xen_pfn_t?

Actually I meant gfn_t, per the followup I sent shortly afterwards.

> I'm having a hard time
> figuring out how to use a pfn_t, I can't even assign
> INVALID_PFN to one.

Documentation in c/s 177bd5f, example in c/s 24036a5.  The point of this

For now, it will require copious use of _gfn() and gfn_x() until the
rest of the mm subsystem has been updated to use the new typesafe types.

~Andrew