From: Stefan Schmidt <stefan@osg.samsung.com>
To: Varka Bhadram <varkabhadram@gmail.com>, linux-wpan@vger.kernel.org
Cc: alex.aring@gmail.com
Subject: Re: [RFC bluetooth-next] mac802154: do not export ieee802154_rx()
Date: Mon, 29 Jun 2015 15:16:06 +0200 [thread overview]
Message-ID: <55914516.1070306@osg.samsung.com> (raw)
In-Reply-To: <1435570267-12971-1-git-send-email-varkabhadram@gmail.com>
Hello.
On 29/06/15 11:31, Varka Bhadram wrote:
> Right now there are no other users for ieee802154_rx()
> in kernel. So lets remove EXPORT_SYMBOL() for this.
>
> Signed-off-by: Varka Bhadram <varkabhadram@gmail.com>
> ---
> net/mac802154/rx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c
> index 5a258c1..7791c9b 100644
> --- a/net/mac802154/rx.c
> +++ b/net/mac802154/rx.c
> @@ -290,7 +290,6 @@ void ieee802154_rx(struct ieee802154_hw *hw, struct sk_buff *skb)
> drop:
> kfree_skb(skb);
> }
> -EXPORT_SYMBOL(ieee802154_rx);
>
> void
> ieee802154_rx_irqsafe(struct ieee802154_hw *hw, struct sk_buff *skb, u8 lqi)
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
Looks good to me. As long as we don't have any pending users this sounds
like a good idea to not expose it until needed.
regards
Stefan Schmidt
next prev parent reply other threads:[~2015-06-29 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 9:31 [RFC bluetooth-next] mac802154: do not export ieee802154_rx() Varka Bhadram
2015-06-29 13:16 ` Stefan Schmidt [this message]
2015-06-29 19:58 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55914516.1070306@osg.samsung.com \
--to=stefan@osg.samsung.com \
--cc=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.