From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v3 1/8] eal: Add pci_uio_alloc_uio_resource()
Date: Tue, 30 Jun 2015 11:31:58 +0900
Message-ID: <5591FF9E.7030102@igel.co.jp>
References: <1432016513-8456-5-git-send-email-mukawa@igel.co.jp>
 <1435546610-4533-1-git-send-email-mukawa@igel.co.jp>
 <1435546610-4533-2-git-send-email-mukawa@igel.co.jp>
 <8CEF83825BEC744B83065625E567D7C204A42D4B@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com
 [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id B4DB7B38D
 for <dev@dpdk.org>; Tue, 30 Jun 2015 04:32:01 +0200 (CEST)
Received: by pabvl15 with SMTP id vl15so114446311pab.1
 for <dev@dpdk.org>; Mon, 29 Jun 2015 19:32:01 -0700 (PDT)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C204A42D4B@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/06/29 22:24, Iremonger, Bernard wrote:
>
>> -----Original Message-----
>> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
>> Sent: Monday, June 29, 2015 3:57 AM
>> To: dev@dpdk.org
>> Cc: Iremonger, Bernard; david.marchand@6wind.com; Tetsuya.Mukawa
>> Subject: [PATCH v3 1/8] eal: Add pci_uio_alloc_uio_resource()
>>
>> From: "Tetsuya.Mukawa" <mukawa@igel.co.jp>
>>
>> This patch adds a new function called pci_uio_alloc_uio_resource().
>> The function hides how to prepare uio resource in linuxapp and bsdapp.
>> With the function, pci_uio_map_resource() will be more abstracted.
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> Hi Tetsuya,
>
> There are two comments inline below.
>
>> ---
>>  lib/librte_eal/bsdapp/eal/eal_pci.c       | 70 +++++++++++++++++++---------
>>  lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 77 ++++++++++++++++++++++---
>> ------
>>  2 files changed, 104 insertions(+), 43 deletions(-)
>>
>> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
>> b/lib/librte_eal/bsdapp/eal/eal_pci.c
>> index 06c564f..2d9f3a5 100644
>> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c
>> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
>> @@ -189,28 +189,17 @@ pci_uio_map_secondary(struct rte_pci_device
>> *dev)
>>  	return 1;
>>  }
>>
>> -/* map the PCI resource of a PCI device in virtual memory */  static int -
>> pci_uio_map_resource(struct rte_pci_device *dev)
>> +pci_uio_alloc_uio_resource(struct rte_pci_device *dev,
>> +		struct mapped_pci_resource **uio_res)
> The name of this function is a bit longwinded,  pci_uio_alloc_resource() might be better.

Hi Bernard,

Thanks for comments.
Sure I will fix it.

>>
>> -/* map the PCI resource of a PCI device in virtual memory */ -int -
>> pci_uio_map_resource(struct rte_pci_device *dev)
>> +static int
>> +pci_uio_alloc_uio_resource(struct rte_pci_device *dev,
>> +		struct mapped_pci_resource **uio_res)
> The name of this function is a bit longwinded,  pci_uio_alloc_resource() might be better.

Also, I will fix above.

Regards,
Tetsuya