All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Bruce Cran <bruce@cran.org.uk>,
	"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: FreeBSD build broken following _Static_assert commit
Date: Mon, 29 Jun 2015 20:48:33 -0600	[thread overview]
Message-ID: <55920381.6060906@kernel.dk> (raw)
In-Reply-To: <5591C7F0.1090004@cran.org.uk>

On 06/29/2015 04:34 PM, Bruce Cran wrote:
> On FreeBSD 10.1 with clang 3.4.1, a standard "gmake" build now fails with:
>
> libfio.c:309:21: error: static_assert expression is not an integral
> constant expression
>          compiletime_assert((offsetof(struct thread_stat,
> percentile_list) % 8) == 0, "stat percentile_list");

Thanks for reporting this, Bruce. No idea why clang complains about 
that, it's definitely a constant expression. Anyway, committed this:

http://git.kernel.dk/cgit/fio/commit/?id=94815a5c8366a9290167e8539f29994c2d43d15c

which adds this sort of check to the configure _Static_assert() check.

-- 
Jens Axboe



  reply	other threads:[~2015-06-30  2:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 22:34 FreeBSD build broken following _Static_assert commit Bruce Cran
2015-06-30  2:48 ` Jens Axboe [this message]
2015-06-30  3:41   ` Bruce Cran
2015-06-30  3:46     ` Jens Axboe
2015-06-30 13:22       ` Bruce Cran
2015-06-30 13:51         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55920381.6060906@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bruce@cran.org.uk \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.