From: Richard Weinberger <richard@nod.at>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dedekind1@gmail.com
Subject: Re: [RFC PATCH RESEND] mtd-utils: Restructure the mtd-utils source.
Date: Tue, 30 Jun 2015 09:38:10 +0200 [thread overview]
Message-ID: <55924762.5010408@nod.at> (raw)
In-Reply-To: <559244FB.8080507@cn.fujitsu.com>
Am 30.06.2015 um 09:27 schrieb Dongsheng Yang:
> On 06/30/2015 03:19 PM, Richard Weinberger wrote:
>> Am 30.06.2015 um 08:50 schrieb Dongsheng Yang:
>>> * There is no code modification in this commit, only moving
>>> * the files to proper place.
>>>
>>> The user tools looks a little messy as we place almost
>>> the all tools in the root directory of mtd-utils. To make
>>> it more clear, I propose to introduce the following structure
>>> for our source code.
>>>
>>> mtd-utils/
>>> |-- lib
>>> |-- include
>>> |-- misc-utils
>>> |-- flash-utils
>>> |-- jffsX-utils
>>> |-- nand-utils
>>> |-- nor-utils
>>> |-- ubi-utils
>>> |-- ubifs-utils
>>> `-- tests
>>>
>>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>>
>> Hmm, while I agree with you that the current directory structure is not perfect
>> I'm not sure if it is worth the hassle. Because your patch hurts git blame.
>
> Good point. But seems the git currently is smart enough to show the
> right history in blame after a rename commit.
Does it also after you've applied the patch file? i.e. git am your.patch.
IIRC git is able to deal with that only if you keep the patch in git.
BTW: Your patch does not apply to mtd-utils.git as of today.
Thanks,
//richard
next prev parent reply other threads:[~2015-06-30 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 6:50 [RFC PATCH RESEND] mtd-utils: Restructure the mtd-utils source Dongsheng Yang
2015-06-30 7:19 ` Richard Weinberger
2015-06-30 7:27 ` Dongsheng Yang
2015-06-30 7:38 ` Richard Weinberger [this message]
2015-06-30 7:41 ` Dongsheng Yang
2015-06-30 9:29 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55924762.5010408@nod.at \
--to=richard@nod.at \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.