All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	lee.jones@linaro.org, sameo@linux.intel.com,
	linux-gpio@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: Use of pinctrl-single for external device over I2C
Date: Tue, 30 Jun 2015 13:28:15 +0530	[thread overview]
Message-ID: <55924C17.6090604@linaro.org> (raw)
In-Reply-To: <55924953.80802@linaro.org>



On Tuesday 30 June 2015 01:16 PM, Vaibhav Hiremath wrote:
>
>
> On Thursday 25 June 2015 11:16 AM, Vaibhav Hiremath wrote:
>>
>>
>> On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote:
>>> * Vaibhav Hiremath <vaibhav.hiremath@linaro.org> [150624 10:12]:
>>>>
>>>> I do not like this, as this is not HW feature, so DT may not be right
>>>> approach.
>>>>
>>>> So I will dig more from either runtime or Compile time option to use
>>>> regmap_ Vs raw read/writes.
>>>
>>> Can't you just check if the pinctrl node has compatible = "syscon"
>>> property?
>>>
>>> A compile time option won't work for sure. I don't know what you
>>> would check at runtime as you do not know what the bus is behind
>>> syscon.
>>>
>>
>> Although, I haven't gone through syscon, but not sure whether syscon
>> would be useful.
>>
>> As you rightly stated, we need to know the bus behind regmap.
>>
>
> Trying to understand what is the right way of doing pinctrl of external
> device on board,
>
> I feel it would not be good idea to pollute pinctrl-single driver, and
> also I am still not able to figure out how can I have access to bus
> behind regmap.
>
>
> How about having separate driver (generic for all I2C), say pinctrl-
> i2c.c, which is i2c_client driver and would support pinctrl and pinmux
> on I2C client device.
>

I mean, part of mfd here (mfd_cell)

>
> The current usecase which I have is pretty simple in nature,
>
> 88PM860 has few GPIO pins which can be configured to different
> functionality, based on board design.
> In most of the cases they are one/init/boot time settings.
>
> GPIO_0:
> =======
>    000 = GPIO input mode
>    001 = GPIO output mode
>    010 = SLEEPOUTN mirror mode
>    011 = Buck4 FPWM enable
>    100 = 32 Khz output buffer mode
>    101 = PMICINTN output mode
>    110 = HW_RESET1 mode
>    111 = HW_RESET2 mode
>
>
> Thanks,
> Vaibhav

WARNING: multiple messages have this Message-ID (diff)
From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: Use of pinctrl-single for external device over I2C
Date: Tue, 30 Jun 2015 13:28:15 +0530	[thread overview]
Message-ID: <55924C17.6090604@linaro.org> (raw)
In-Reply-To: <55924953.80802@linaro.org>



On Tuesday 30 June 2015 01:16 PM, Vaibhav Hiremath wrote:
>
>
> On Thursday 25 June 2015 11:16 AM, Vaibhav Hiremath wrote:
>>
>>
>> On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote:
>>> * Vaibhav Hiremath <vaibhav.hiremath@linaro.org> [150624 10:12]:
>>>>
>>>> I do not like this, as this is not HW feature, so DT may not be right
>>>> approach.
>>>>
>>>> So I will dig more from either runtime or Compile time option to use
>>>> regmap_ Vs raw read/writes.
>>>
>>> Can't you just check if the pinctrl node has compatible = "syscon"
>>> property?
>>>
>>> A compile time option won't work for sure. I don't know what you
>>> would check at runtime as you do not know what the bus is behind
>>> syscon.
>>>
>>
>> Although, I haven't gone through syscon, but not sure whether syscon
>> would be useful.
>>
>> As you rightly stated, we need to know the bus behind regmap.
>>
>
> Trying to understand what is the right way of doing pinctrl of external
> device on board,
>
> I feel it would not be good idea to pollute pinctrl-single driver, and
> also I am still not able to figure out how can I have access to bus
> behind regmap.
>
>
> How about having separate driver (generic for all I2C), say pinctrl-
> i2c.c, which is i2c_client driver and would support pinctrl and pinmux
> on I2C client device.
>

I mean, part of mfd here (mfd_cell)

>
> The current usecase which I have is pretty simple in nature,
>
> 88PM860 has few GPIO pins which can be configured to different
> functionality, based on board design.
> In most of the cases they are one/init/boot time settings.
>
> GPIO_0:
> =======
>    000 = GPIO input mode
>    001 = GPIO output mode
>    010 = SLEEPOUTN mirror mode
>    011 = Buck4 FPWM enable
>    100 = 32 Khz output buffer mode
>    101 = PMICINTN output mode
>    110 = HW_RESET1 mode
>    111 = HW_RESET2 mode
>
>
> Thanks,
> Vaibhav

  reply	other threads:[~2015-06-30  7:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 10:55 Use of pinctrl-single for external device over I2C Vaibhav Hiremath
2015-06-24 12:04 ` Vaibhav Hiremath
2015-06-24 12:04   ` Vaibhav Hiremath
2015-06-24 13:33   ` Tony Lindgren
2015-06-24 13:33     ` Tony Lindgren
2015-06-24 17:10     ` Vaibhav Hiremath
2015-06-24 17:10       ` Vaibhav Hiremath
2015-06-25  4:38       ` Tony Lindgren
2015-06-25  4:38         ` Tony Lindgren
2015-06-25  5:46         ` Vaibhav Hiremath
2015-06-25  5:46           ` Vaibhav Hiremath
2015-06-30  7:46           ` Vaibhav Hiremath
2015-06-30  7:46             ` Vaibhav Hiremath
2015-06-30  7:58             ` Vaibhav Hiremath [this message]
2015-06-30  7:58               ` Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55924C17.6090604@linaro.org \
    --to=vaibhav.hiremath@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.