From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9rIG-0007gw-JQ for qemu-devel@nongnu.org; Tue, 30 Jun 2015 04:53:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9rIF-00087O-Nv for qemu-devel@nongnu.org; Tue, 30 Jun 2015 04:53:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9r0q-0000D2-KC for qemu-devel@nongnu.org; Tue, 30 Jun 2015 04:35:28 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 376C28E77B for ; Tue, 30 Jun 2015 08:35:28 +0000 (UTC) Message-ID: <559254CC.4000106@redhat.com> Date: Tue, 30 Jun 2015 16:35:24 +0800 From: Jason Wang MIME-Version: 1.0 References: <1435633611-14023-1-git-send-email-famz@redhat.com> In-Reply-To: <1435633611-14023-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , "Michael S. Tsirkin" On 06/30/2015 11:06 AM, Fam Zheng wrote: > virtio_net_receive still does the check by calling > virtio_net_can_receive, if the device or driver is not ready, the packet > is dropped. > > This is necessary because returning false from can_receive complicates > things: the peer would disable sending until we explicitly flush the > queue. > > Signed-off-by: Fam Zheng > --- > hw/net/virtio-net.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index d728233..dbef0d0 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -1503,7 +1503,6 @@ static int virtio_net_load_device(VirtIODevice *vdev, QEMUFile *f, > static NetClientInfo net_virtio_info = { > .type = NET_CLIENT_OPTIONS_KIND_NIC, > .size = sizeof(NICState), > - .can_receive = virtio_net_can_receive, > .receive = virtio_net_receive, > .link_status_changed = virtio_net_set_link_status, > .query_rx_filter = virtio_net_query_rxfilter, A side effect of this patch is it will read and then drop packet is guest driver is no ok.