From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: fix building error
Date: Tue, 30 Jun 2015 16:55:52 +0800
Message-ID: <55925998.6080703@cn.fujitsu.com>
References: <559232B9.3060403@cn.fujitsu.com>
	<1435652795.21469.2.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1435652795.21469.2.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Yang Hongyang <yanghy@cn.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 06/30/2015 04:26 PM, Ian Campbell wrote:
> On Tue, 2015-06-30 at 14:10 +0800, Wen Congyang wrote:
> 
> It would be usual do describe here which commit caused the breakage
> (i.e. removed the parameter). Also please make the subject something
> more descriptive such as "remove now unnecessary gc from
> libxl__async_exec_start calls" e.g.
> 
> Subject: remove now unnecessary gc from libxl__async_exec_start calls
> 
> These were removed in commit XXXXXX.

OK, I will repost it.

Thanks
Wen Congyang

> 
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>>  tools/libxl/libxl_netbuffer.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c
>> index ff2d6c7..107e867 100644
>> --- a/tools/libxl/libxl_netbuffer.c
>> +++ b/tools/libxl/libxl_netbuffer.c
>> @@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev)
>>      }
>>  
>>      setup_async_exec(dev, "setup");
>> -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
>> +    rc = libxl__async_exec_start(&dev->aodev.aes);
>>      if (rc)
>>          goto out;
>>  
>> @@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)
>>  
>>      setup_async_exec(dev, "teardown");
>>  
>> -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
>> +    rc = libxl__async_exec_start(&dev->aodev.aes);
>>      if (rc)
>>          goto out;
>>  
> 
> 
> .
>