From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2] remove now unnecessary gc from
 libxl__async_exec_start calls
Date: Tue, 30 Jun 2015 10:19:39 +0100
Message-ID: <55925F2B.50000@citrix.com>
References: <55925984.1080504@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55925984.1080504@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>, xen devel <xen-devel@lists.xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 30/06/15 09:55, Wen Congyang wrote:
> These were removed in commit f5f8400f.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
>  tools/libxl/libxl_netbuffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c
> index ff2d6c7..107e867 100644
> --- a/tools/libxl/libxl_netbuffer.c
> +++ b/tools/libxl/libxl_netbuffer.c
> @@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev)
>      }
>  
>      setup_async_exec(dev, "setup");
> -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> +    rc = libxl__async_exec_start(&dev->aodev.aes);
>      if (rc)
>          goto out;
>  
> @@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)
>  
>      setup_async_exec(dev, "teardown");
>  
> -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> +    rc = libxl__async_exec_start(&dev->aodev.aes);
>      if (rc)
>          goto out;
>  

Can OSS test be updated to build the remus bits of libxl?  This failure
should not have been able to pass the push gate.

~Andrew