Re: [PATCH V2 4/5] [media] cxd2841er: Sony CXD2841ER DVB-S/S2/T/T2/C demodulator driver

[Kozlov Sergey <serjk@netup.ru>]

Hi Mauro,

Thanks for your review.
I started work on V3 patch series, and found no information about 
roll-off handling in the CDX2841 demodulator chip documentation. It 
seemks that roll-off is handled automatically.

Best regards,
Sergey

14.05.2015 17:15, Mauro Carvalho Chehab пишет:
> Em Wed, 15 Apr 2015 13:07:49 +0300
> serjk@netup.ru escreveu:
>> +
>> +static int cxd2841er_set_frontend_s(struct dvb_frontend *fe)
>> +{
>> +	int ret = 0, i, timeout, carr_offset;
>> +	fe_status_t status;
>> +	struct cxd2841er_priv *priv = fe->demodulator_priv;
>> +	struct dtv_frontend_properties *p = &fe->dtv_property_cache;
>> +	u32 symbol_rate = p->symbol_rate/1000;
>> +
>> +	dev_dbg(&priv->i2c->dev, "%s(): %s frequency=%d symbol_rate=%d\n",
>> +		__func__,
>> +		(p->delivery_system == SYS_DVBS ? "DVB-S" : "DVB-S2"),
>> +		 p->frequency, symbol_rate);
>
> I was unable to identify how ROLLOFF is handled for DVB-S2 in this code.
>