From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] docs: Fix docs output after commit 6592bf6 Date: Tue, 30 Jun 2015 14:16:19 +0100 Message-ID: <559296A3.2020600@citrix.com> References: <1435666937-31354-1-git-send-email-julien.grall@citrix.com> <55928D02.5060007@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z9vPH-0005ta-5j for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 13:16:59 +0000 In-Reply-To: <55928D02.5060007@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Andrew, On 30/06/15 13:35, Andrew Cooper wrote: > On 30/06/15 13:22, Julien Grall wrote: >> A find option was forgotten in commit 6592bf60beaf1fa0b4fd36fb73800eb001c739af >> "docs: Look for documentation in sub-directories" resulting to get some >> docs duplicated and other missing. >> >> Signed-off-by: Julien Grall >> --- >> docs/Makefile | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/docs/Makefile b/docs/Makefile >> index 0ee6808..272292c 100644 >> --- a/docs/Makefile >> +++ b/docs/Makefile >> @@ -10,9 +10,9 @@ DOC_ARCHES := arm x86_32 x86_64 >> MAN1SRC-y += $(sort $(shell find man -name 'xl*.pod.1' -print)) >> MAN1SRC-y += $(sort $(shell find man -name 'xenstore*.pod.1' -print)) >> >> -MAN5SRC-y := $(sort $(shell find man 'xl*.pod.5' -print)) >> +MAN5SRC-y := $(sort $(shell find man -name 'xl*.pod.5' -print)) > > All of the sources should look for *.pod.1 and *.pod.5, without being > more specific about an xl or a xenstore prefix. > > They were only like that because of limitations with the older > $(wildcard ...) invocation. What kind of limitations? Similar pattern were used to match markdown and txt. In anycase, the patch which replaced wildcard by find retains the same behavior. Changing the pattern is not a bug and should be part of a separate patch. Feel free to send a follow-up. Regards, -- Julien Grall