From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"Rafael J. Wysocki"
<rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's
Date: Tue, 30 Jun 2015 16:56:54 +0300 [thread overview]
Message-ID: <5592A026.3010200@gmail.com> (raw)
In-Reply-To: <CAAVeFuKcaz1C9OV26+8A+LypScqDcufR+X99KDJwVui39Nq7xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
30.06.2015 16:42, Alexandre Courbot пишет:
> On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
>> for ACPI") removed possibility to request GPIO by table index for non-ACPI
>> platforms without changing it users. As result "shutdown" GPIO request
>> will fail if request for "reset" GPIO succeeded or "reset" will be
>> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
>> setting conn_id's in gpiod_lookup_table.
>
> Yep, and using con_ids is a good idea anyway.
>
> Acked-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
After discussion on irc, turned out that patch missed
s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2.
And s/conn_id/con_id typo started to annoy me...
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: digetx@gmail.com (Dmitry Osipenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's
Date: Tue, 30 Jun 2015 16:56:54 +0300 [thread overview]
Message-ID: <5592A026.3010200@gmail.com> (raw)
In-Reply-To: <CAAVeFuKcaz1C9OV26+8A+LypScqDcufR+X99KDJwVui39Nq7xA@mail.gmail.com>
30.06.2015 16:42, Alexandre Courbot ?????:
> On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko <digetx@gmail.com> wrote:
>> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
>> for ACPI") removed possibility to request GPIO by table index for non-ACPI
>> platforms without changing it users. As result "shutdown" GPIO request
>> will fail if request for "reset" GPIO succeeded or "reset" will be
>> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
>> setting conn_id's in gpiod_lookup_table.
>
> Yep, and using con_ids is a good idea anyway.
>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
>
After discussion on irc, turned out that patch missed
s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2.
And s/conn_id/con_id typo started to annoy me...
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Marc Dietrich <marvin24@gmx.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Stable <stable@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's
Date: Tue, 30 Jun 2015 16:56:54 +0300 [thread overview]
Message-ID: <5592A026.3010200@gmail.com> (raw)
In-Reply-To: <CAAVeFuKcaz1C9OV26+8A+LypScqDcufR+X99KDJwVui39Nq7xA@mail.gmail.com>
30.06.2015 16:42, Alexandre Courbot пишет:
> On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko <digetx@gmail.com> wrote:
>> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
>> for ACPI") removed possibility to request GPIO by table index for non-ACPI
>> platforms without changing it users. As result "shutdown" GPIO request
>> will fail if request for "reset" GPIO succeeded or "reset" will be
>> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
>> setting conn_id's in gpiod_lookup_table.
>
> Yep, and using con_ids is a good idea anyway.
>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
>
After discussion on irc, turned out that patch missed
s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2.
And s/conn_id/con_id typo started to annoy me...
--
Dmitry
next prev parent reply other threads:[~2015-06-30 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 19:34 [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's Dmitry Osipenko
2015-06-28 19:34 ` Dmitry Osipenko
2015-06-28 19:34 ` Dmitry Osipenko
[not found] ` <1435520160-16862-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-30 13:42 ` Alexandre Courbot
2015-06-30 13:42 ` Alexandre Courbot
2015-06-30 13:42 ` Alexandre Courbot
[not found] ` <CAAVeFuKcaz1C9OV26+8A+LypScqDcufR+X99KDJwVui39Nq7xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-30 13:56 ` Dmitry Osipenko [this message]
2015-06-30 13:56 ` Dmitry Osipenko
2015-06-30 13:56 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5592A026.3010200@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.