From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's Date: Tue, 30 Jun 2015 16:56:54 +0300 Message-ID: <5592A026.3010200@gmail.com> References: <1435520160-16862-1-git-send-email-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Courbot Cc: Thierry Reding , Stephen Warren , Marc Dietrich , Mika Westerberg , "Rafael J. Wysocki" , Stable , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List List-Id: linux-tegra@vger.kernel.org 30.06.2015 16:42, Alexandre Courbot =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko w= rote: >> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver map= pings >> for ACPI") removed possibility to request GPIO by table index for no= n-ACPI >> platforms without changing it users. As result "shutdown" GPIO reque= st >> will fail if request for "reset" GPIO succeeded or "reset" will be >> requested instead of "shutdown" if "reset" wasn't defined. Fix it by >> setting conn_id's in gpiod_lookup_table. > > Yep, and using con_ids is a good idea anyway. > > Acked-by: Alexandre Courbot > After discussion on irc, turned out that patch missed=20 s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2. And s/conn_id/con_id typo started to annoy me... --=20 Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: digetx@gmail.com (Dmitry Osipenko) Date: Tue, 30 Jun 2015 16:56:54 +0300 Subject: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's In-Reply-To: References: <1435520160-16862-1-git-send-email-digetx@gmail.com> Message-ID: <5592A026.3010200@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 30.06.2015 16:42, Alexandre Courbot ?????: > On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko wrote: >> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings >> for ACPI") removed possibility to request GPIO by table index for non-ACPI >> platforms without changing it users. As result "shutdown" GPIO request >> will fail if request for "reset" GPIO succeeded or "reset" will be >> requested instead of "shutdown" if "reset" wasn't defined. Fix it by >> setting conn_id's in gpiod_lookup_table. > > Yep, and using con_ids is a good idea anyway. > > Acked-by: Alexandre Courbot > After discussion on irc, turned out that patch missed s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2. And s/conn_id/con_id typo started to annoy me... -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753187AbbF3N6x (ORCPT ); Tue, 30 Jun 2015 09:58:53 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:34919 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbbF3N6T (ORCPT ); Tue, 30 Jun 2015 09:58:19 -0400 Message-ID: <5592A026.3010200@gmail.com> Date: Tue, 30 Jun 2015 16:56:54 +0300 From: Dmitry Osipenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexandre Courbot CC: Thierry Reding , Stephen Warren , Marc Dietrich , Mika Westerberg , "Rafael J. Wysocki" , Stable , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's References: <1435520160-16862-1-git-send-email-digetx@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 30.06.2015 16:42, Alexandre Courbot пишет: > On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko wrote: >> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings >> for ACPI") removed possibility to request GPIO by table index for non-ACPI >> platforms without changing it users. As result "shutdown" GPIO request >> will fail if request for "reset" GPIO succeeded or "reset" will be >> requested instead of "shutdown" if "reset" wasn't defined. Fix it by >> setting conn_id's in gpiod_lookup_table. > > Yep, and using con_ids is a good idea anyway. > > Acked-by: Alexandre Courbot > After discussion on irc, turned out that patch missed s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2. And s/conn_id/con_id typo started to annoy me... -- Dmitry