From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 12/15] xen/arm: gic: Store the necessary HW information per vGIC ... Date: Tue, 30 Jun 2015 15:11:52 +0100 Message-ID: <5592A3A8.3080404@citrix.com> References: <1435311269-3189-1-git-send-email-julien.grall@citrix.com> <1435311269-3189-13-git-send-email-julien.grall@citrix.com> <1435668976.21469.138.camel@citrix.com> <55929BCA.1060107@citrix.com> <1435672817.21469.179.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z9wIM-0002dl-1G for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 14:13:54 +0000 In-Reply-To: <1435672817.21469.179.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 30/06/15 15:00, Ian Campbell wrote: >>>> +static inline void vgic_v2_setup_hw(paddr_t dbase, paddr_t cbase, >>>> + paddr_t vbase) >>>> +{ >>>> + vgic_v2_hw.enabled = 1; >>>> + vgic_v2_hw.dbase = dbase; >>>> + vgic_v2_hw.cbase = cbase; >>>> + vgic_v2_hw.vbase = vbase; >>>> +} >>> >>> If you were to move this out of line into vgic-v2.c would that mean that >>> vgic_v2_hw_config etc could be static to that file? >> >> No, we have to access the field enabled in domain_vgic_init to verify >> the GIC is supporting the version of the vGIC. > > That's a shame. > > vgic_vN_init would have been the ideal place to test for this, which > would have kept everything in one place, but you've just nuked that and > I suppose don't want it coming back. I dropped vgic_vN_init because it was only setting the ops. I don't mind to remove the patch #3 and move all the structure in vgic-v*.c. It will be a lot cleaner. Regards, -- Julien Grall