From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] libxl: locally attach disks with hotplug scripts for bootloader execution Date: Tue, 30 Jun 2015 15:15:15 +0100 Message-ID: <5592A473.1020403@eu.citrix.com> References: <1435241865-82765-1-git-send-email-roger.pau@citrix.com> <558C38EE.80103@eu.citrix.com> <1435667719.21469.127.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z9wKG-0002tg-JJ for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 14:15:52 +0000 In-Reply-To: <1435667719.21469.127.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org On 06/30/2015 01:35 PM, Ian Campbell wrote: > On Thu, 2015-06-25 at 18:22 +0100, George Dunlap wrote: >> Although having said that -- isn't there also a bug here wrt qdisk >> backends in a driver domain not being attached? >> >> Could we do something like the attached patch? > > As an alternative (rather than an incremental) to Roger's, right? > > I didn't have any comments (i.e. LGTM) but I was hoping for an ack or > R-by/T-by from Roger. I think he was waiting for me to confirm that it would work with blktap, which I haven't had time to test yet. Or rather, I've tested it with my new use-blktap-scripts-rather-than-the-library patches, but we want to avoid regressions if we can. -George