From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Tamas K Lengyel <tlengyel@novetta.com>, xen-devel@lists.xen.org
Cc: stefano.stabellini@citrix.com, keir@xen.org,
rcojocaru@bitdefender.com, jbeulich@suse.com,
ian.campbell@citrix.com
Subject: Re: [PATCH v2] x86/vm_event: toggle singlestep from vm_event response
Date: Tue, 30 Jun 2015 15:18:06 +0100 [thread overview]
Message-ID: <5592A51E.1050200@citrix.com> (raw)
In-Reply-To: <1435673482-10674-1-git-send-email-tlengyel@novetta.com>
On 30/06/15 15:11, Tamas K Lengyel wrote:
> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h
> index 577e971..b8c3dde 100644
> --- a/xen/include/public/vm_event.h
> +++ b/xen/include/public/vm_event.h
> @@ -44,9 +44,15 @@
> * paused
> * VCPU_PAUSED in a response signals to unpause the vCPU
> */
> -#define VM_EVENT_FLAG_VCPU_PAUSED (1 << 0)
> -/* Flags to aid debugging mem_event */
> -#define VM_EVENT_FLAG_FOREIGN (1 << 1)
> +#define VM_EVENT_FLAG_VCPU_PAUSED (1 << 0)
> +/* Flag to aid debugging mem_event */
> +#define VM_EVENT_FLAG_FOREIGN (1 << 1)
> +/*
> + * Toggle singlestepping on vm_event response.
> + * Requires the vCPU to be paused already (synchronous events only).
> + * Only supported on Intel CPUs with MTF capability.
This sentence shouldn't be in the public API. It is a limitation of the
current implementation, not of the API, and could be removed with
further development.
With this removed, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> + */
> +#define VM_EVENT_FLAG_TOGGLE_SINGLESTEP (1 << 2)
>
> /*
> * Reasons for the vm event request
next prev parent reply other threads:[~2015-06-30 14:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 14:11 [PATCH v2] x86/vm_event: toggle singlestep from vm_event response Tamas K Lengyel
2015-06-30 14:18 ` Andrew Cooper [this message]
2015-06-30 14:40 ` Lengyel, Tamas
2015-07-06 15:26 ` Jan Beulich
2015-07-06 15:35 ` Lengyel, Tamas
2015-07-06 15:54 ` Jan Beulich
2015-07-06 16:26 ` Lengyel, Tamas
2015-07-06 17:03 ` Razvan Cojocaru
2015-07-06 17:08 ` Lengyel, Tamas
2015-07-06 17:17 ` Andrew Cooper
2015-07-06 17:29 ` Razvan Cojocaru
2015-07-06 17:36 ` Lengyel, Tamas
2015-07-06 17:45 ` Andrew Cooper
2015-07-06 17:44 ` Andrew Cooper
2015-07-07 6:20 ` Jan Beulich
2015-07-07 6:26 ` Razvan Cojocaru
2015-07-07 9:27 ` Jan Beulich
2015-07-07 11:56 ` Lengyel, Tamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5592A51E.1050200@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=rcojocaru@bitdefender.com \
--cc=stefano.stabellini@citrix.com \
--cc=tlengyel@novetta.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.