From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2] x86/vm_event: toggle singlestep from vm_event response Date: Tue, 30 Jun 2015 15:18:06 +0100 Message-ID: <5592A51E.1050200@citrix.com> References: <1435673482-10674-1-git-send-email-tlengyel@novetta.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435673482-10674-1-git-send-email-tlengyel@novetta.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xen.org Cc: stefano.stabellini@citrix.com, keir@xen.org, rcojocaru@bitdefender.com, jbeulich@suse.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 30/06/15 15:11, Tamas K Lengyel wrote: > diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h > index 577e971..b8c3dde 100644 > --- a/xen/include/public/vm_event.h > +++ b/xen/include/public/vm_event.h > @@ -44,9 +44,15 @@ > * paused > * VCPU_PAUSED in a response signals to unpause the vCPU > */ > -#define VM_EVENT_FLAG_VCPU_PAUSED (1 << 0) > -/* Flags to aid debugging mem_event */ > -#define VM_EVENT_FLAG_FOREIGN (1 << 1) > +#define VM_EVENT_FLAG_VCPU_PAUSED (1 << 0) > +/* Flag to aid debugging mem_event */ > +#define VM_EVENT_FLAG_FOREIGN (1 << 1) > +/* > + * Toggle singlestepping on vm_event response. > + * Requires the vCPU to be paused already (synchronous events only). > + * Only supported on Intel CPUs with MTF capability. This sentence shouldn't be in the public API. It is a limitation of the current implementation, not of the API, and could be removed with further development. With this removed, Reviewed-by: Andrew Cooper > + */ > +#define VM_EVENT_FLAG_TOGGLE_SINGLESTEP (1 << 2) > > /* > * Reasons for the vm event request