From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v4][PATCH 12/19] tools/libxl: passes rdm reservation policy Date: Wed, 01 Jul 2015 09:30:00 +0800 Message-ID: <55934298.7000605@intel.com> References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com> <1435053450-25131-13-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Ian Jackson , Stefano Stabellini , Wei Liu , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 2015/7/1 0:11, George Dunlap wrote: > On Tue, Jun 23, 2015 at 10:57 AM, Tiejun Chen wrote: >> This patch passes our rdm reservation policy inside libxl >> when we assign a device or attach a device. > > Actually, it looks like what you need to do here, both for this patch > and the previous one is to add "rdm_reserve" to libxlu_pci.c, so that > it gets handled on a per-device level just like permissive, > msitranslate, &c. That would make it Just Work for both domain config > and for the pci hotplug (and any other toolstacks using the xlu > functions to parse BDFs). > We'd like to separate this kind of thing into two patches respectively to make this patch series bisectable and readable. And actually this split is suggested by Wei during our previous review, I think his advice should make sense. Thanks Tiejun