From: "Jindal, Sonika" <sonika.jindal@intel.com>
To: Vandana Kannan <vandana.kannan@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bxt: BUNs related to port PLL
Date: Wed, 01 Jul 2015 09:51:16 +0530 [thread overview]
Message-ID: <55936ABC.1020908@intel.com> (raw)
In-Reply-To: <1435725395-4365-1-git-send-email-vandana.kannan@intel.com>
On 7/1/2015 10:06 AM, Vandana Kannan wrote:
> This patch contains changes based on 2 updates to the spec:
> Port PLL VCO restriction raised up to 6700.
> Port PLL now needs DCO amp override enable for all VCO frequencies.
>
> Signed-off-by: Vandana Kannan <vandana.kannan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 7 +++----
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 42c1487..677096d 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1495,8 +1495,8 @@ bxt_ddi_pll_select(struct intel_crtc *intel_crtc,
> }
>
> dco_amp = 15;
> - dcoampovr_en_h = 0;
> - if (vco >= 6200000 && vco <= 6480000) {
> + dcoampovr_en_h = 1;
You dont need this variable now..
> + if (vco >= 6200000 && vco <= 6700000) {
> prop_coef = 4;
> int_coef = 9;
> gain_ctl = 3;
> @@ -1550,8 +1550,7 @@ bxt_ddi_pll_select(struct intel_crtc *intel_crtc,
>
> crtc_state->dpll_hw_state.pll8 = targ_cnt;
>
> - if (dcoampovr_en_h)
> - crtc_state->dpll_hw_state.pll10 = PORT_PLL_DCO_AMP_OVR_EN_H;
> + crtc_state->dpll_hw_state.pll10 = PORT_PLL_DCO_AMP_OVR_EN_H;
>
> crtc_state->dpll_hw_state.pll10 |= PORT_PLL_DCO_AMP(dco_amp);
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index eb665d7..e04be45 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -409,7 +409,7 @@ static const intel_limit_t intel_limits_chv = {
> static const intel_limit_t intel_limits_bxt = {
> /* FIXME: find real dot limits */
> .dot = { .min = 0, .max = INT_MAX },
> - .vco = { .min = 4800000, .max = 6480000 },
> + .vco = { .min = 4800000, .max = 6700000 },
> .n = { .min = 1, .max = 1 },
> .m1 = { .min = 2, .max = 2 },
> /* FIXME: find real m2 limits */
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-01 4:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 4:36 [PATCH] drm/i915/bxt: BUNs related to port PLL Vandana Kannan
2015-07-01 4:21 ` Jindal, Sonika [this message]
2015-07-01 4:50 ` Kannan, Vandana
2015-07-01 5:34 ` [PATCH v2] " Vandana Kannan
2015-07-01 9:31 ` Jindal, Sonika
2015-07-01 10:18 ` Sivakumar Thulasimani
2015-07-01 10:42 ` Kannan, Vandana
2015-07-01 11:32 ` [PATCH v3] " Vandana Kannan
2015-07-01 11:11 ` Sivakumar Thulasimani
2015-07-03 4:53 ` Kannan, Vandana
2015-07-06 8:08 ` Kannan, Vandana
2015-07-06 8:21 ` Daniel Vetter
2015-07-04 11:01 ` shuang.he
2015-07-02 23:39 ` [PATCH v2] " shuang.he
2015-07-02 21:02 ` [PATCH] " shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55936ABC.1020908@intel.com \
--to=sonika.jindal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vandana.kannan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.