From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: "Weiny, Ira" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V2] IB/mad: Remove improper use of BUG_ON
Date: Wed, 1 Jul 2015 10:43:23 +0300 [thread overview]
Message-ID: <55939A1B.5030307@mellanox.com> (raw)
In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E110A343B-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 6/25/2015 6:23 PM, Weiny, Ira wrote:
>> On 6/25/2015 4:52 PM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
>>> From: Ira Weiny<ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>>
>>> We recently added BUG_ON's which were inappropriate for a condition
>>> which should never happen. Change these to be WARN_ON_ONCE as a
>> debugging aid.
>>> Fixes: 4cd7c9479aff ('IB/mad: Add support for additional MAD info
>>> to/from drivers')
>>>
>>> Signed-off-by: Ira Weiny<ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>> remove the blank line,
> Is there some documentation on this stuff?
I don't know
>
> This does not mention anything about white space.
>
> https://www.kernel.org/doc/Documentation/SubmittingPatches
>
> I don't mind following the proper conventions if I knew what they were.
so look around a bit... e.g on networking patches and see that no blank
lines.. it's add sort of small eye damaging for someone looking on
kernel logs.
Or.
>
> Ira
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-07-01 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 13:52 [PATCH V2] IB/mad: Remove improper use of BUG_ON ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1435240370-18161-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-25 15:06 ` Or Gerlitz
[not found] ` <558C18DF.6010307-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-06-25 15:23 ` Weiny, Ira
[not found] ` <2807E5FD2F6FDA4886F6618EAC48510E110A343B-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-07-01 7:43 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55939A1B.5030307@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.