All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][PATCH] libconnman-qt5: new recipe
Date: Wed, 01 Jul 2015 11:44:40 +0200	[thread overview]
Message-ID: <5593B688.4070304@opendreambox.org> (raw)
In-Reply-To: <1435741531-30306-1-git-send-email-net147@gmail.com>

Hello Jonathan,

On 01.07.2015 11:05, Jonathan Liu wrote:
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  recipes-qt/libconnman-qt/libconnman-qt5_git.bb | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 recipes-qt/libconnman-qt/libconnman-qt5_git.bb
> 
> diff --git a/recipes-qt/libconnman-qt/libconnman-qt5_git.bb b/recipes-qt/libconnman-qt/libconnman-qt5_git.bb
> new file mode 100644
> index 0000000..0ca57e2
> --- /dev/null
> +++ b/recipes-qt/libconnman-qt/libconnman-qt5_git.bb
> @@ -0,0 +1,17 @@
> +require recipes-qt/qt5/qt5.inc
> +
> +SUMMARY = "Qt Library for ConnMan"
> +HOMEPAGE = "https://github.com/nemomobile/libconnman-qt"
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://libconnman-qt/clockmodel.h;endline=8;md5=ea9f724050803f15d2d900ce3c5dac88"
> +DEPENDS += "qtbase qtdeclarative"
> +PV = "1.0.89+git${SRCPV}"
> +
> +SRCREV = "79a8d10479ba55951ffa375a66797eedff230dd3"
> +SRC_URI = "git://github.com/nemomobile/libconnman-qt.git"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig
> +
> +RDEPENDS_${PN} += "connman"

I have a slightly different version in my meta-qt5 repo (fido):

https://github.com/opendreambox/meta-qt5/commit/9e616b42e266f1c804daae1eb5dcf693c0f07b42

Can you please compare both versions and make sure that the things you
omitted aren't needed anymore? Note that libconnman-qt.inc is equal to
the version in meta-openembedded.

Regards,
Andreas


  reply	other threads:[~2015-07-01  9:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01  9:05 [meta-qt5][PATCH] libconnman-qt5: new recipe Jonathan Liu
2015-07-01  9:44 ` Andreas Oberritter [this message]
2015-07-01 13:19   ` Martin Jansa
2015-07-01 13:49     ` Jonathan Liu
2015-07-02 11:46       ` Felipe Tonello
2015-07-02 15:18         ` Jonathan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5593B688.4070304@opendreambox.org \
    --to=obi@opendreambox.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.