From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v4] dmar: device scope mem leak fix
Date: Wed, 1 Jul 2015 11:00:45 +0100
Message-ID: <5593BA4D.7000409@citrix.com>
References: <1435706410-24751-1-git-send-email-elena.ufimtseva@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1435706410-24751-1-git-send-email-elena.ufimtseva@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: elena.ufimtseva@oracle.com, xen-devel@lists.xen.org
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, tim@xen.org, boris.ostrovsky@oracle.com, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On 01/07/15 00:20, elena.ufimtseva@oracle.com wrote:
> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -81,6 +81,13 @@ static int __init acpi_register_rmrr_unit(struct acpi_rmrr_unit *rmrr)
>      return 0;
>  }
>  
> +static void scope_devices_free(struct dmar_scope *scope)
> +{
> +    if ( scope )
> +        scope->devices_cnt = 0;
> +    xfree(scope->devices);

This is very liable to suffer a NULL pointer dereference.

~Andrew