From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAEsy-00029w-HQ for qemu-devel@nongnu.org; Wed, 01 Jul 2015 06:05:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAEst-000142-Rz for qemu-devel@nongnu.org; Wed, 01 Jul 2015 06:04:56 -0400 Received: from [59.151.112.132] (port=33382 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAEst-0000zk-HE for qemu-devel@nongnu.org; Wed, 01 Jul 2015 06:04:51 -0400 Message-ID: <5593BB3D.9000009@cn.fujitsu.com> Date: Wed, 1 Jul 2015 18:04:45 +0800 From: Yang Hongyang MIME-Version: 1.0 References: <1435740693-10839-1-git-send-email-quintela@redhat.com> <1435740693-10839-10-git-send-email-quintela@redhat.com> In-Reply-To: <1435740693-10839-10-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/12] migration: Use always helper to set state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, dgilbert@redhat.com On 07/01/2015 04:51 PM, Juan Quintela wrote: > There were three places that were not using the migrate_set_state() > helper, just fix that. > > Signed-off-by: Juan Quintela Reviewed-by: Yang Hongyang > --- > migration/migration.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index c5b778b..a8d2da5 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -548,7 +548,7 @@ void migrate_fd_error(MigrationState *s) > { > trace_migrate_fd_error(); > assert(s->file == NULL); > - s->state = MIGRATION_STATUS_FAILED; > + migrate_set_state(s, MIGRATION_STATUS_SETUP, MIGRATION_STATUS_FAILED); > trace_migrate_set_state(MIGRATION_STATUS_FAILED); > notifier_list_notify(&migration_state_notifiers, s); > } > @@ -633,7 +633,7 @@ static MigrationState *migrate_init(const MigrationParams *params) > s->parameters[MIGRATION_PARAMETER_DECOMPRESS_THREADS] = > decompress_thread_count; > s->bandwidth_limit = bandwidth_limit; > - s->state = MIGRATION_STATUS_SETUP; > + migrate_set_state(s, MIGRATION_STATUS_NONE, MIGRATION_STATUS_SETUP); > trace_migrate_set_state(MIGRATION_STATUS_SETUP); > > s->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); > @@ -732,7 +732,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, > } else { > error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "uri", > "a valid migration protocol"); > - s->state = MIGRATION_STATUS_FAILED; > + migrate_set_state(s, MIGRATION_STATUS_SETUP, MIGRATION_STATUS_FAILED); > return; > } > -- Thanks, Yang.