From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [v4][PATCH 12/19] tools/libxl: passes rdm
 reservation policy
Date: Wed, 1 Jul 2015 11:31:13 +0100
Message-ID: <5593C171.40809@eu.citrix.com>
References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com>
	<1435053450-25131-13-git-send-email-tiejun.chen@intel.com>
	<CAFLBxZYf0qwHvRjWWwVsODJtR-HxHA+m5ZmS7=VEwOmLANRrng@mail.gmail.com>
	<55934298.7000605@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55934298.7000605@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 07/01/2015 02:30 AM, Chen, Tiejun wrote:
> On 2015/7/1 0:11, George Dunlap wrote:
>> On Tue, Jun 23, 2015 at 10:57 AM, Tiejun Chen <tiejun.chen@intel.com>
>> wrote:
>>> This patch passes our rdm reservation policy inside libxl
>>> when we assign a device or attach a device.
>>
>> Actually, it looks like what you need to do here, both for this patch
>> and the previous one is to add "rdm_reserve" to libxlu_pci.c, so that
>> it gets handled on a per-device level just like permissive,
>> msitranslate, &c.  That would make it Just Work for both domain config
>> and for the pci hotplug (and any other toolstacks using the xlu
>> functions to parse BDFs).
>>
> 
> We'd like to separate this kind of thing into two patches respectively
> to make this patch series bisectable and readable. And actually this
> split is suggested by Wei during our previous review, I think his advice
> should make sense.

I'm not only suggesting changing the layout of the patches; I'm
suggesting modifying the functionality.

In patch 12 you add a new command-line parameter to xl; so that you have
to type something like this:

# xl pci-attach ubuntu01 01:00.1,msitranslate=1 relaxed

What I'm saying is that you can drop the xl part of that patch entirely,
because once you have the xlu code in, you can just do this:

# xl pci-attach ubuntu01 01:00.1,msitranslate=1,rdm_reserve=relaxed

This has the positive advantage that you can copy and paste the same
string into both the xl command and the xl config file.

 -George