From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v4] drm/i915: Report correct GGTT space usage
Date: Wed, 01 Jul 2015 11:53:43 +0100 [thread overview]
Message-ID: <5593C6B7.1080104@linux.intel.com> (raw)
In-Reply-To: <20150630150050.GG1381@nuc-i3427.alporthouse.com>
On 06/30/2015 04:00 PM, Chris Wilson wrote:
> On Tue, Jun 30, 2015 at 03:32:47PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Currently only normal views were accounted which under-accounts
>> the usage as reported in debugfs.
>>
>> Introduce new helper, i915_gem_obj_total_ggtt_size, and use it
>> from call sites which want to know how much GGTT space are
>> objects using.
>>
>> v2: Single loop in i915_gem_get_aperture_ioctl. (Chris Wilson)
>>
>> v3: Walk GGTT active/inactive lists in i915_gem_get_aperture_ioctl
>> for better efficiency. (Chris Wilson, Daniel Vetter)
>>
>> v4: Make i915_gem_obj_total_ggtt_size private to debugfs. (Chris Wilson)
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> s/unsigned long/u64/
It's all pointless until someone makes it all consistent. But done
anyway. And sent as a new thread so Daniel hopefully notices it more easily.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-01 10:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 9:28 [PATCH] drm/i915: Report correct GGTT space usage Tvrtko Ursulin
2015-06-30 9:36 ` Chris Wilson
2015-06-30 9:50 ` Tvrtko Ursulin
2015-06-30 10:01 ` Chris Wilson
2015-06-30 10:27 ` [PATCH v2] " Tvrtko Ursulin
2015-06-30 10:33 ` Chris Wilson
2015-06-30 11:03 ` Tvrtko Ursulin
2015-06-30 11:35 ` Chris Wilson
2015-06-30 12:53 ` [PATCH v3] " Tvrtko Ursulin
2015-06-30 13:30 ` Chris Wilson
2015-06-30 14:32 ` [PATCH v4] " Tvrtko Ursulin
2015-06-30 15:00 ` Chris Wilson
2015-07-01 10:53 ` Tvrtko Ursulin [this message]
2015-07-01 10:58 ` Chris Wilson
2015-07-02 7:30 ` shuang.he
2015-07-02 0:23 ` [PATCH v3] " shuang.he
2015-07-01 20:01 ` [PATCH v2] " shuang.he
2015-07-01 17:58 ` [PATCH] " shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593C6B7.1080104@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=joonas.lahtinen@linux.intel.com \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.