From: Heiko Schocher denx <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] siemens,am33x: adjust mtd partition
Date: Wed, 01 Jul 2015 13:13:46 +0200 [thread overview]
Message-ID: <5593CB6A.6020408@denx.de> (raw)
In-Reply-To: <1435741478-6743-1-git-send-email-samuel.egli@siemens.com>
Hallo Samuel,
Am 01.07.2015 um 11:04 schrieb Samuel Egli:
> Use one mtd partition for rootfs and configuration by
> means of ubi volumes and get rid of configuration partition.
> We can use partition layout for both 256MB and 512MB flash.
>
> Signed-off-by: Samuel Egli <samuel.egli@siemens.com>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Roger Meier <r.meier@siemens.com>
> ---
> include/configs/siemens-am33x-common.h | 33 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 17 deletions(-)
only one nitpick ...
> diff --git a/include/configs/siemens-am33x-common.h b/include/configs/siemens-am33x-common.h
> index 120647f..eddb868 100644
> --- a/include/configs/siemens-am33x-common.h
> +++ b/include/configs/siemens-am33x-common.h
> @@ -486,7 +486,7 @@
>
> /*
> * Variant 2 partition layout
> - * chip-size = 256MiB
> + * chip-size = 256MiB or 512 MiB
> *| name | size | address area |
> *-------------------------------------------------------
> *| spl | 128.000 KiB | 0x 0..0x 1ffff |
> @@ -496,23 +496,23 @@
> *| u-boot | 1.875 MiB | 0x 80000..0x 25ffff |
> *| uboot.env0 | 512.000 KiB | 0x 260000..0x 2Dffff |
> *| uboot.env1 | 512.000 KiB | 0x 2E0000..0x 35ffff |
> - *| rootfs | 148.000 MiB | 0x 360000..0x 975ffff |
> - *| mtdoops | 512.000 KiB | 0x 9760000..0x 98Dffff |
> - *|configuration | 104.125 MiB | 0x 97E0000..0x fffffff |
> + *| mtdoops | 512.000 KiB | 0x 360000..0x 3dffff |
> + *| (256) rootfs | 252.125 MiB | 0x 3E0000..0x fffffff |
> + *| (512) rootfs | 508.125 MiB | 0x 3E0000..0x1fffffff |
> *-------------------------------------------------------
> */
>
> #define MTDPARTS_DEFAULT_V2 "mtdparts=" MTDIDS_NAME_STR ":" \
> - "128k(spl)," \
> - "128k(spl.backup1)," \
> - "128k(spl.backup2)," \
> - "128k(spl.backup3)," \
> - "1920k(u-boot)," \
> - "512k(u-boot.env0)," \
> - "512k(u-boot.env1)," \
> - "148m(rootfs)," \
> - "512k(mtdoops)," \
> - "-(configuration)"
> + "128k(spl)," \
> + "128k(spl.backup1)," \
> + "128k(spl.backup2)," \
> + "128k(spl.backup3)," \
> + "1920k(u-boot)," \
> + "512k(u-boot.env0)," \
> + "512k(u-boot.env1)," \
> + "512k(mtdoops)," \
> + "-(rootfs)"
You name the partition "rootfs" .. but it contains not only the
rootfs, instead it contains now 2 or more UBI volumes ...
Maybe a rename it to "ubi" or "ubivolumes" or ... makes this clearer?
Beside of this, you can add my:
Acked-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
> +
>
> #define DFU_ALT_INFO_NAND_V2 \
> "spl part 0 1;" \
> @@ -522,8 +522,7 @@
> "u-boot part 0 5;" \
> "u-boot.env0 part 0 6;" \
> "u-boot.env1 part 0 7;" \
> - "rootfs partubi 0 8;" \
> - "configuration partubi 0 10"
> + "rootfs partubi 0 9" \
>
> #define CONFIG_ENV_SETTINGS_NAND_V2 \
> "nand_active_ubi_vol=rootfs_a\0" \
> @@ -540,7 +539,7 @@
> "setenv nand_active_ubi_vol ${rootfs_name}_b;" \
> "fi;" \
> "setenv nand_root ubi0:${nand_active_ubi_vol} rw " \
> - "ubi.mtd=7,2048 ubi.mtd=9,2048;" \
> + "ubi.mtd=8,2048;" \
> "setenv bootargs ${bootargs} " \
> "root=${nand_root} noinitrd ${mtdparts} " \
> "rootfstype=${nand_root_fs_type} ip=${ip_method} " \
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-07-01 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 9:04 [U-Boot] [PATCH] siemens,am33x: adjust mtd partition Samuel Egli
2015-07-01 10:49 ` Meier, Roger
2015-07-01 11:13 ` Heiko Schocher denx [this message]
2015-07-01 12:00 ` Egli, Samuel
2015-07-01 15:03 ` Tom Rini
2015-07-01 15:57 ` [U-Boot] [PATCH v2] " Samuel Egli
2015-07-01 19:37 ` Tom Rini
2015-07-02 4:28 ` Heiko Schocher denx
2015-07-10 12:57 ` [U-Boot] [U-Boot,v2] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593CB6A.6020408@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.