From: Sohny Thomas <sohnythomas@zoho.com>
To: Frans Klaver <fransklaver@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
arve@android.com, riandrews@android.com, sumit.semwal@linaro.org,
carlos@cgarcia.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: android: fix coding style and TODO file
Date: Wed, 1 Jul 2015 18:08:22 +0530 [thread overview]
Message-ID: <5593DF3E.3030206@zoho.com> (raw)
In-Reply-To: <CAH6sp9Pj0Ta60RJAhQrLe++jO3rZHxeTkEcf9rnTL75d=Qoszg@mail.gmail.com>
On Wednesday 01 July 2015 05:59 PM, Frans Klaver wrote:
> On Wed, Jul 1, 2015 at 2:22 PM, Sohny Thomas <sohnythomas@zoho.com> wrote:
>>
>>
>> On Wednesday 01 July 2015 05:37 PM, Frans Klaver wrote:
>>> On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas <sohnythomas@zoho.com> wrote:
>>>> - removed non-existant issue from TODO file
>>>
>>> s,existant,existent,
>> Thanks missed that
>>>
>>>> kuid_t or uid_t not present in staging/android
>>>> - fixed 80 char limit exceeding line
>>>> - a newline after decelartions as per checkpatch.pl
>>>> - fixed an unnecessary typedef as reported by checkpatch.pl
>>>
>>> Fix one issue per patch, please.
>> Since these were all simple Fixes of about 1/2 lines , I thought to make a single patch.
>
> They are simple fixes, but a reviewer still has to figure out what
> comment belongs to which code change. Since there's no reason for
> these changes to be atomic, you might as well split them up to make
> reviewing easier.
>
Yeap, V2 coming with changes and fixes Sudip's catch too.
Thanks for your time.
-Sohny
> Frans
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2015-07-01 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 11:56 [PATCH] Staging: android: fix coding style and TODO file Sohny Thomas
2015-07-01 12:07 ` Frans Klaver
2015-07-01 12:19 ` Sudip Mukherjee
2015-07-01 12:22 ` Sohny Thomas
2015-07-01 12:29 ` Frans Klaver
2015-07-01 12:38 ` Sohny Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593DF3E.3030206@zoho.com \
--to=sohnythomas@zoho.com \
--cc=arve@android.com \
--cc=carlos@cgarcia.org \
--cc=fransklaver@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.