All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Grandel <fgrandel@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Lukasz Rymanowski <lukasz.rymanowski@tieto.com>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Szymon Janc <Szymon.Janc@tieto.com>,
	BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: Peripheral role support for android
Date: Wed, 01 Jul 2015 15:39:42 +0200	[thread overview]
Message-ID: <5593ED9E.4040907@gmail.com> (raw)
In-Reply-To: <650B748F-76F8-4031-9397-E65D18AD01A4@holtmann.org>

>> AFAICS there is (at least) one catch: the kernel does not support setting custom values for min/max adv interval, channel map, tx power, etc. while the HAL API seems to expect per-instance setup of these values. How should we deal with this? Should we ignore these values? Or should we error out with a NOT_SUPPORTED error if they are different from the kernel defaults?
>
> We never exposed the channel map since that is pretty much stupid. I would just ignore that parameter. Just accept whatever it asks of and see okay, I will do it, even if you don't in the end.
>
> The TX power you could set whatever you want, but I would advise against it. Just accept the TX power you get from the HAL and then set Include TX Power flag. I mean the best you can do is check if TX Power is included or not. And allow the advertising data to reflect this.
>
> And min/max advertising interval is also something you should ignore. Actually that is something an application should never be in control of anyway. Choosing bad parameters might cause the controller to make a choice between BR/EDR and LE in its schedule. And for obvious reasons, the application has not knowledge of the BR/EDR state. So just accept them and go on with it.
>
>> Please let me know whether you agree to that roadmap and what you think about the unsupported features. Is it ok if I try to tackle these todos? Or is someone working on this already?
>
> Go ahead.
>
> Regards
>
> Marcel

Thanks Marcel! All questions answered. :-)

Florian

  reply	other threads:[~2015-07-01 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-27  0:05 Peripheral role support for android Florian Grandel
2015-06-29 13:52 ` Marcel Holtmann
2015-07-01 13:39   ` Florian Grandel [this message]
2015-07-19 22:42   ` Florian Grandel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5593ED9E.4040907@gmail.com \
    --to=fgrandel@gmail.com \
    --cc=Szymon.Janc@tieto.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=lukasz.rymanowski@tieto.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.