From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t Date: Wed, 1 Jul 2015 14:53:54 +0100 Message-ID: <5593F0F2.8020802@citrix.com> References: <1435758095-20821-1-git-send-email-Ben.Catterall@citrix.com> <1435758095-20821-2-git-send-email-Ben.Catterall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZAITB-0005ZW-Et for xen-devel@lists.xenproject.org; Wed, 01 Jul 2015 13:54:33 +0000 In-Reply-To: <1435758095-20821-2-git-send-email-Ben.Catterall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ben Catterall , xen-devel@lists.xenproject.org Cc: keir@xen.org, ian.campbell@citrix.com, George Dunlap , tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org On 01/07/15 14:41, Ben Catterall wrote: > From: Andrew Cooper > > The sh_map/unmap wrappers can be dropped, and take the opportunity to turn > some #define's into static inlines, for added type saftey. > > As part of adding the type safety, GCC highlights an problematic include cycle > with arm/mm.h including domain_page.h which includes xen/mm.h and falls over > __page_to_mfn being used before being declared. Simply dropping the inclusion > of domain_page.h fixes the compilation issue. > > Signed-off-by: Andrew Cooper > CC: Jan Beulich > CC: Tim Deegan > CC: Ian Campbell > CC: Stefano Stabellini One thing to note is that the mm maintainer has changed since I wrote this patch. CC'ing George with his new hat on. (The same applies to all patches in this series) ~Andrew