From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAItn-0006Fg-Cp for qemu-devel@nongnu.org; Wed, 01 Jul 2015 10:22:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAIth-0000FS-KZ for qemu-devel@nongnu.org; Wed, 01 Jul 2015 10:22:03 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:14682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAIth-0000EU-9H for qemu-devel@nongnu.org; Wed, 01 Jul 2015 10:21:57 -0400 Message-ID: <5593F781.7090307@imgtec.com> Date: Wed, 1 Jul 2015 15:21:53 +0100 From: Yongbok Kim MIME-Version: 1.0 References: <1435569083-47502-1-git-send-email-yongbok.kim@imgtec.com> <20150701134837.GO931@aurel32.net> <5593F1B1.6030905@imgtec.com> <20150701140654.GP931@aurel32.net> In-Reply-To: <20150701140654.GP931@aurel32.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: fix MIPS64R6-generic configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: leon.alrae@imgtec.com, qemu-devel@nongnu.org On 01/07/2015 15:06, Aurelien Jarno wrote: > On 2015-07-01 14:57, Yongbok Kim wrote: >> On 01/07/2015 14:48, Aurelien Jarno wrote: >>> On 2015-06-29 10:11, Yongbok Kim wrote: >>>> Fix core configuration for MIPS64R6-generic to make it as close as >>>> I6400. >>>> I6400 core has 48-bit of Virtual Address available (SEGBITS). >>>> MIPS SIMD Architecture is available. >>>> Rearrange order of bits to match the specification. >>>> >>>> Signed-off-by: Yongbok Kim >>>> --- >>>> target-mips/mips-defs.h | 2 +- >>>> target-mips/translate_init.c | 18 +++++++++--------- >>>> 2 files changed, 10 insertions(+), 10 deletions(-) >>> >>> Reviewed-by: Aurelien Jarno >>> >>> That said given we are getting closer to the I6400 CPU model, shouldn't >>> we try to directly model a I6400 core (even if we have to disable some >>> features like IEEE 754-2008 FP) instead of a generic MIPS64R6 core? >>> >> >> I fully agree with that but detailed specification of I6400 has not been >> published yet, therefore for the time being we will need to use the generic > > Oh ok. > >> core name. However we could rename mips32r5-generic into P5600 with such >> restrictions - Hardware page table walk, Virtualization, EVA. >> What do you think? > > I think it's a good idea, as long as we keep the config register in sync > with what is actually implemented. > I will form a patch to do that. > That also reminds me that we should look at implementing hardware page > table walk. That should be relatively easy to implement, and provide a > huge performance boost (exceptions cost a lot on QEMU). > Actually I have implemented HTW (for MIPS32 only) but due to lack of resources, I couldn't upstream it for 2.4. Please have a look at below commits. https://github.com/yongbok/prpl-qemu/commit/b39e60b4039bb72ab5eccabfb75f6e6389d89bfd https://github.com/yongbok/prpl-qemu/commit/4fd75126c1d78d84a91c659de17a5bc45efdef27 Regards, Yongbok