From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode Date: Wed, 01 Jul 2015 17:05:33 +0100 Message-ID: <55940FCD.5070901@arm.com> References: <1435684740-24912-1-git-send-email-gregory.clement@free-electrons.com> <1435684740-24912-4-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.101.70]:46259 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbbGAQFj (ORCPT ); Wed, 1 Jul 2015 12:05:39 -0400 In-Reply-To: <1435684740-24912-4-git-send-email-gregory.clement@free-electrons.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Gregory CLEMENT , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth Cc: Sudeep Holla , Thomas Petazzoni , Boris BREZILLON , Tawfik Bayouk , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Nadav Haklai , Lior Amsalem , Ezequiel Garcia , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" On 30/06/15 18:18, Gregory CLEMENT wrote: > On the Armada 375/38x/39x SoCs, in standby mode the SoCs stay powered > and it is possible to wake-up from any interrupt sources. This patch > adds flag to the GIC irqchip driver to let linux know this. > > Signed-off-by: Gregory CLEMENT > --- > arch/arm/mach-mvebu/board-v7.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c > index e5911defccac..f446230e7416 100644 > --- a/arch/arm/mach-mvebu/board-v7.c > +++ b/arch/arm/mach-mvebu/board-v7.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -26,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -129,6 +131,11 @@ static int armada_375_external_abort_wa(unsigned long addr, unsigned int fsr, > > static void __init mvebu_init_irq(void) > { > + if (of_machine_is_compatible("marvell,armada375") || > + of_machine_is_compatible("marvell,armada380") || > + of_machine_is_compatible("marvell,armada390")) > + gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE | > + IRQCHIP_MASK_ON_SUSPEND); I am planning to add these flags in the GIC driver itself and remove this function. I will post the patch next week once merge window closes next, so based on how that discussion proceeds you may have drop this patch, just heads up. Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Wed, 01 Jul 2015 17:05:33 +0100 Subject: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode In-Reply-To: <1435684740-24912-4-git-send-email-gregory.clement@free-electrons.com> References: <1435684740-24912-1-git-send-email-gregory.clement@free-electrons.com> <1435684740-24912-4-git-send-email-gregory.clement@free-electrons.com> Message-ID: <55940FCD.5070901@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30/06/15 18:18, Gregory CLEMENT wrote: > On the Armada 375/38x/39x SoCs, in standby mode the SoCs stay powered > and it is possible to wake-up from any interrupt sources. This patch > adds flag to the GIC irqchip driver to let linux know this. > > Signed-off-by: Gregory CLEMENT > --- > arch/arm/mach-mvebu/board-v7.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c > index e5911defccac..f446230e7416 100644 > --- a/arch/arm/mach-mvebu/board-v7.c > +++ b/arch/arm/mach-mvebu/board-v7.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -26,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -129,6 +131,11 @@ static int armada_375_external_abort_wa(unsigned long addr, unsigned int fsr, > > static void __init mvebu_init_irq(void) > { > + if (of_machine_is_compatible("marvell,armada375") || > + of_machine_is_compatible("marvell,armada380") || > + of_machine_is_compatible("marvell,armada390")) > + gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE | > + IRQCHIP_MASK_ON_SUSPEND); I am planning to add these flags in the GIC driver itself and remove this function. I will post the patch next week once merge window closes next, so based on how that discussion proceeds you may have drop this patch, just heads up. Regards, Sudeep