From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 2/3] xen/domain_page: Convert
 copy/clear_domain_page() to using mfn_t
Date: Wed, 1 Jul 2015 17:07:05 +0100
Message-ID: <55941029.3050804@citrix.com>
References: <1435758095-20821-1-git-send-email-Ben.Catterall@citrix.com>
	<1435758095-20821-3-git-send-email-Ben.Catterall@citrix.com>
	<5593F1CC.4040207@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=61724f3fe=david.vrabel@citrix.com>)
	id 1ZAKax-0005Pv-3i
	for xen-devel@lists.xenproject.org; Wed, 01 Jul 2015 16:10:43 +0000
In-Reply-To: <5593F1CC.4040207@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Ben Catterall <Ben.Catterall@citrix.com>, xen-devel@lists.xenproject.org
Cc: keir@xen.org, ian.campbell@citrix.com, George Dunlap <george.dunlap@eu.citrix.com>, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, jbeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

On 01/07/15 14:57, Andrew Cooper wrote:
> On 01/07/15 14:41, Ben Catterall wrote:
>> From: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> [Convert grant_table.c to pass mfn_t types and fix ARM compiling]
>>
>> Signed-off-by: Ben Catterall <Ben.Catterall@citrix.com>
> 
> Reviwed-by: Andrew Cooper <andrew.cooper3@citrix.com> for the additions
> beyond my half of the patch.
> 
> Also CC'ing George and David as maintainers of areas touched.

For this sort of tree-wide mechanical change I wouldn't generally
expected to need acks/reviews from specific subsystem maintainers.

I'm not sure I see the point of this series.

>> --- a/xen/common/kimage.c
>> +++ b/xen/common/kimage.c
>> @@ -77,7 +77,7 @@ static struct page_info *kimage_alloc_zeroed_page(unsigned memflags)
>>      if ( !page )
>>          return NULL;
>>  
>> -    clear_domain_page(page_to_mfn(page));
>> +    clear_domain_page(_mfn(page_to_mfn(page)));

Seems odd that page_to_mfn() doesn't return the correct type and needs
the "cast".

David