From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 3/9] kvm: add hyper-v crash msrs values Date: Wed, 1 Jul 2015 18:48:06 +0200 Message-ID: <559419C6.6020204@redhat.com> References: <1435664007-4965-1-git-send-email-den@openvz.org> <1435664007-4965-4-git-send-email-den@openvz.org> <55940074.1010606@redhat.com> <55940D15.9050108@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Andrey Smetanin , Gleb Natapov To: Peter Hornyack , "Denis V. Lunev" Return-path: Received: from mail-wi0-f177.google.com ([209.85.212.177]:37691 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116AbbGAQsJ (ORCPT ); Wed, 1 Jul 2015 12:48:09 -0400 Received: by wicgi11 with SMTP id gi11so51059172wic.0 for ; Wed, 01 Jul 2015 09:48:08 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 01/07/2015 18:06, Peter Hornyack wrote: > If userspace is controlling the crash capabilities then > HV_X64_MSR_CRASH_CTL_CONTENTS is not needed. Actually you still need to: userspace cannot write anything but 0 or (1ULL << 63). However, the name makes less sense, so I'm in favor of removing the value. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZALBG-0005Cp-1l for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:48:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZALBB-0008P5-Fw for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:48:13 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:34670) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZALBB-0008NW-8c for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:48:09 -0400 Received: by wgqq4 with SMTP id q4so41929691wgq.1 for ; Wed, 01 Jul 2015 09:48:08 -0700 (PDT) Sender: Paolo Bonzini References: <1435664007-4965-1-git-send-email-den@openvz.org> <1435664007-4965-4-git-send-email-den@openvz.org> <55940074.1010606@redhat.com> <55940D15.9050108@openvz.org> From: Paolo Bonzini Message-ID: <559419C6.6020204@redhat.com> Date: Wed, 1 Jul 2015 18:48:06 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Hornyack , "Denis V. Lunev" Cc: Andrey Smetanin , Gleb Natapov , qemu-devel@nongnu.org, kvm@vger.kernel.org On 01/07/2015 18:06, Peter Hornyack wrote: > If userspace is controlling the crash capabilities then > HV_X64_MSR_CRASH_CTL_CONTENTS is not needed. Actually you still need to: userspace cannot write anything but 0 or (1ULL << 63). However, the name makes less sense, so I'm in favor of removing the value. Paolo