All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Peter Hung <hpeter@gmail.com>, jdelvare@suse.de
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
	tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw,
	Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [lm-sensors] [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting
Date: Wed, 01 Jul 2015 21:04:07 +0000	[thread overview]
Message-ID: <559455C7.3030002@roeck-us.net> (raw)
In-Reply-To: <1435627870-12249-3-git-send-email-hpeter+linux_kernel@gmail.com>

Hi Peter,

On 06/29/2015 06:31 PM, Peter Hung wrote:
> The temperature value of Fintek F81866 is the same with
> f71882fg. It located with 0x6c + 2*(nr), others located
> with 0x6c + 2*(nr+1). We change the rule in f71882fg_probe(),
> If type = f71858fg/f8000/f81866a. the temp_start will set to 0,
> others are 1.
>
> The F81866 over-temperature beep setting is not the same with
> f71882fg too. They are using the same address 63H, but F81866 is
> using bit 0/1/2 & 4/5/6, others are using bit 1/2/3 & 5/6/7,
> So we copy from fxxxx_temp_beep_attr[] to f81866_temp_beep_attr
> and change bit setting.
>
> Signed-off-by: Peter Hung <hpeter+linux_kernel@gmail.com>
> ---
[ .. ]

> +			if (data->type = f81866a) {
> +				size = ARRAY_SIZE(f81866_temp_beep_attr[0]);
> +				err = f71882fg_create_sysfs_files(pdev,
> +						&f81866_temp_beep_attr[0][0],
> +						size * nr_temps);
> +
> +			} else {
> +				size = ARRAY_SIZE(fxxxx_temp_beep_attr[0];

TskTsk ... turns out you didn't even compile test this code.

How am I supposed to know that it is working ?

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Peter Hung <hpeter@gmail.com>, jdelvare@suse.de
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
	tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw,
	Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting
Date: Wed, 01 Jul 2015 14:04:07 -0700	[thread overview]
Message-ID: <559455C7.3030002@roeck-us.net> (raw)
In-Reply-To: <1435627870-12249-3-git-send-email-hpeter+linux_kernel@gmail.com>

Hi Peter,

On 06/29/2015 06:31 PM, Peter Hung wrote:
> The temperature value of Fintek F81866 is the same with
> f71882fg. It located with 0x6c + 2*(nr), others located
> with 0x6c + 2*(nr+1). We change the rule in f71882fg_probe(),
> If type = f71858fg/f8000/f81866a. the temp_start will set to 0,
> others are 1.
>
> The F81866 over-temperature beep setting is not the same with
> f71882fg too. They are using the same address 63H, but F81866 is
> using bit 0/1/2 & 4/5/6, others are using bit 1/2/3 & 5/6/7,
> So we copy from fxxxx_temp_beep_attr[] to f81866_temp_beep_attr
> and change bit setting.
>
> Signed-off-by: Peter Hung <hpeter+linux_kernel@gmail.com>
> ---
[ .. ]

> +			if (data->type == f81866a) {
> +				size = ARRAY_SIZE(f81866_temp_beep_attr[0]);
> +				err = f71882fg_create_sysfs_files(pdev,
> +						&f81866_temp_beep_attr[0][0],
> +						size * nr_temps);
> +
> +			} else {
> +				size = ARRAY_SIZE(fxxxx_temp_beep_attr[0];

TskTsk ... turns out you didn't even compile test this code.

How am I supposed to know that it is working ?

Guenter


  reply	other threads:[~2015-07-01 21:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30  1:31 [lm-sensors] [PATCH V2 0/3] hwmon:f71882fg add new Fintek SuperIO support Peter Hung
2015-06-30  1:31 ` Peter Hung
2015-06-30  1:31 ` [lm-sensors] [PATCH V2 1/3] hwmon:f71882fg add f81866/f71868 " Peter Hung
2015-06-30  1:31   ` Peter Hung
2015-06-30  1:31 ` [lm-sensors] [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting Peter Hung
2015-06-30  1:31   ` Peter Hung
2015-07-01 21:04   ` Guenter Roeck [this message]
2015-07-01 21:04     ` Guenter Roeck
2015-07-02  3:08     ` [lm-sensors] " Peter Hung
2015-07-02  3:08       ` Peter Hung
2015-06-30  1:31 ` [lm-sensors] [PATCH V2 3/3] hwmon:f71882fg fix f81866a voltage protection Peter Hung
2015-06-30  1:31   ` Peter Hung
2015-07-01 17:53 ` [lm-sensors] [PATCH V2 0/3] hwmon:f71882fg add new Fintek SuperIO support Guenter Roeck
2015-07-01 17:53   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559455C7.3030002@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=hpeter@gmail.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=peter_hong@fintek.com.tw \
    --cc=tom_tsai@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.