From: Nathan_Lynch@mentor.com (Nathan Lynch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix vdsomunge not to depend on glibc specific error.h
Date: Wed, 1 Jul 2015 17:11:14 -0500 [thread overview]
Message-ID: <55946582.4010602@mentor.com> (raw)
In-Reply-To: <20150630110557.GG27725@arm.com>
On 06/30/2015 06:05 AM, Will Deacon wrote:
> On Tue, Jun 30, 2015 at 11:48:29AM +0100, Szabolcs Nagy wrote:
>> If the host toolchain is not glibc based then the arm kernel build
>> fails with
>>
>> arch/arm/vdso/vdsomunge.c:53:19: fatal error: error.h: No such file or directory
>>
>> error.h is a glibc only header (ie not available in musl, newlib and
>> bsd libcs). Changed the error reporting to standard conforming code
>> to avoid depending on specific C implementations.
>>
>> Signed-off-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
>> ---
>> arch/arm/vdso/vdsomunge.c | 56 ++++++++++++++++++++++++++-------------------
>> 1 file changed, 33 insertions(+), 23 deletions(-)
>
> Looks fine to me:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Probably worth a Cc stable too.
Agreed and thanks; submitted to Russell's patch system as 8397/1.
next prev parent reply other threads:[~2015-07-01 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 10:48 [PATCH] ARM: fix vdsomunge not to depend on glibc specific error.h Szabolcs Nagy
2015-06-30 11:05 ` Will Deacon
2015-07-01 22:11 ` Nathan Lynch [this message]
2015-07-01 22:27 ` Russell King - ARM Linux
2015-07-01 22:29 ` Nathan Lynch
2015-07-01 22:30 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55946582.4010602@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.