From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hung Date: Thu, 02 Jul 2015 03:08:43 +0000 Subject: Re: [lm-sensors] [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting Message-Id: <5594AB3B.90301@gmail.com> List-Id: References: <1435627870-12249-1-git-send-email-hpeter+linux_kernel@gmail.com> <1435627870-12249-3-git-send-email-hpeter+linux_kernel@gmail.com> <559455C7.3030002@roeck-us.net> In-Reply-To: <559455C7.3030002@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck , jdelvare@suse.de Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung SGkgR3VlbnRlciwKCkd1ZW50ZXIgUm9lY2sg5pa8IDIwMTUvNy8yIOS4iuWNiCAwNTowNCDlr6vp gZM6Cj4gSGkgUGV0ZXIsCj4+ICsgICAgICAgICAgICB9IGVsc2Ugewo+PiArICAgICAgICAgICAg ICAgIHNpemUgPSBBUlJBWV9TSVpFKGZ4eHh4X3RlbXBfYmVlcF9hdHRyWzBdOwo+Cj4gVHNrVHNr IC4uLiB0dXJucyBvdXQgeW91IGRpZG4ndCBldmVuIGNvbXBpbGUgdGVzdCB0aGlzIGNvZGUuCj4g SG93IGFtIEkgc3VwcG9zZWQgdG8ga25vdyB0aGF0IGl0IGlzIHdvcmtpbmcgPwoKU29ycnksIEl0 J3MgbXkgZmF1bHQuCkkgc2hvdWxkIHJlLXRlc3RpbmcgcGF0Y2ggYWZ0ZXIgZml4IGNoZWNrcGF0 Y2guc2ggd2FybmluZ3MuCgpJJ2xsIHJlLWNvbmZpcm0gYWxsIHBhdGNoZXMgYWdhaW4gYmVmb3Jl IHNlbmQgaXQgdG8gbWFpbnRhaW5lci4KCi0tIApXaXRoIEJlc3QgUmVnYXJkcywKUGV0ZXIgSHVu ZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vu c29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMu bG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753131AbbGBDIq (ORCPT ); Wed, 1 Jul 2015 23:08:46 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:35098 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbbGBDIp (ORCPT ); Wed, 1 Jul 2015 23:08:45 -0400 Subject: Re: [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting To: Guenter Roeck , jdelvare@suse.de References: <1435627870-12249-1-git-send-email-hpeter+linux_kernel@gmail.com> <1435627870-12249-3-git-send-email-hpeter+linux_kernel@gmail.com> <559455C7.3030002@roeck-us.net> Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung From: Peter Hung Message-ID: <5594AB3B.90301@gmail.com> Date: Thu, 2 Jul 2015 11:08:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <559455C7.3030002@roeck-us.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, Guenter Roeck 於 2015/7/2 上午 05:04 寫道: > Hi Peter, >> + } else { >> + size = ARRAY_SIZE(fxxxx_temp_beep_attr[0]; > > TskTsk ... turns out you didn't even compile test this code. > How am I supposed to know that it is working ? Sorry, It's my fault. I should re-testing patch after fix checkpatch.sh warnings. I'll re-confirm all patches again before send it to maintainer. -- With Best Regards, Peter Hung