Re: [PATCH for 3.14.y stable 18/22] arm/arm64: KVM: Require in-kernel vgic for the arch timers

[Shannon Zhao <shannon.zhao@linaro.org>]

On 2015/7/2 2:36, Greg KH wrote:
> On Tue, Jun 30, 2015 at 06:49:06PM +0800, shannon.zhao@linaro.org wrote:
>> From: Christoffer Dall <christoffer.dall@linaro.org>
>>
>> commit 05971120fca43e0357789a14b3386bb56eef2201 upstream.
>>
>> It is curently possible to run a VM with architected timers support
>> without creating an in-kernel VGIC, which will result in interrupts from
>> the virtual timer going nowhere.
>>
>> To address this issue, move the architected timers initialization to the
>> time when we run a VCPU for the first time, and then only initialize
>> (and enable) the architected timers if we have a properly created and
>> initialized in-kernel VGIC.
>>
>> When injecting interrupts from the virtual timer to the vgic, the
>> current setup should ensure that this never calls an on-demand init of
>> the VGIC, which is the only call path that could return an error from
>> kvm_vgic_inject_irq(), so capture the return value and raise a warning
>> if there's an error there.
>>
>> We also change the kvm_timer_init() function from returning an int to be
>> a void function, since the function always succeeds.
>>
>> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
>> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> 
> {sigh}
> 
> You modified this patch and didn't say you modified it, despite me
> asking you to do so.  
I don't think so. If you really have a look at this patch, you should
recognize that this patch is doing the same thing as the original patch
does.

> Why should I trust that the other patches you sent
Trust? Don't say that please. I never felt your trust even from the
beginning of this backport.

> weren't also modified?
> 
> Ugh.  I've stopped here in the series, and I'm really annoyed at this
> whole series and just how long it's taken to get this right for a
> feature that almost no one cares about...
> 
> greg k-h
> 

-- 
Shannon