From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v2 1/5] drm/rockchip: vop: optimize virtual stride calculate Date: Thu, 02 Jul 2015 14:13:11 +0800 Message-ID: <5594D677.20202@rock-chips.com> References: <1435313249-4549-1-git-send-email-mark.yao@rock-chips.com> <1435313249-4549-2-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomasz Figa Cc: xw@rock-chips.com, zwl@rock-chips.com, "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , dri-devel , dkm@rock-chips.com, sandy.huang@rock-chips.com, "linux-arm-kernel@lists.infradead.org" List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDA35pyIMDLml6UgMTI6NTksIFRvbWFzeiBGaWdhIHdyb3RlOgo+IE9uIEZyaSwg SnVuIDI2LCAyMDE1IGF0IDc6MDcgUE0sIE1hcmsgWWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNv bT4gd3JvdGU6Cj4+IHZpcl9zdHJpZGUgbmVlZCBudW1iZXIgd29yZHMgb2YgdGhlIHZpcnR1YWwg d2lkdGgsIGFuZCBmYi0+cGl0Y2hlcwo+PiBzYXZlIGJ5dGVzX3Blcl9waXhlbCwgc28ganVzdCBk aXYgNCBzd2l0Y2ggdG8gc3RyaWRlLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYXJrIFlhbyA8bWFy ay55YW9Acm9jay1jaGlwcy5jb20+Cj4+IC0tLQo+PiBDaGFuZ2VzIGluIHYyOiBOb25lCj4+Cj4+ ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyB8ICAgIDIgKy0K Pj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPj4KPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMg Yi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jCj4+IGluZGV4IDYx ODgyMjEuLjNjOWY0ZjMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9y b2NrY2hpcF9kcm1fdm9wLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tj aGlwX2RybV92b3AuYwo+PiBAQCAtNjQ0LDcgKzY0NCw3IEBAIHN0YXRpYyBpbnQgdm9wX3VwZGF0 ZV9wbGFuZV9ldmVudChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPj4gICAgICAgICAgb2Zmc2V0 ICs9IChzcmMueTEgPj4gMTYpICogZmItPnBpdGNoZXNbMF07Cj4+ICAgICAgICAgIHlyZ2JfbXN0 ID0gcmtfb2JqLT5kbWFfYWRkciArIG9mZnNldDsKPj4KPj4gLSAgICAgICB5X3Zpcl9zdHJpZGUg PSBmYi0+cGl0Y2hlc1swXSAvIChmYi0+Yml0c19wZXJfcGl4ZWwgPj4gMyk7Cj4+ICsgICAgICAg eV92aXJfc3RyaWRlID0gZmItPnBpdGNoZXNbMF0gPj4gMjsKPiBJZiB0aGUgdW5pdCBvZiB5X3Zp cl9zdHJpZGUgaXMgd29yZHMgdGhlbiBkb2Vzbid0IGl0IG1lYW4gdGhhdCB0aGUKPiBjYWxjdWxh dGlvbiBiZWZvcmUgdGhpcyBwYXRjaCB3YXMganVzdCBpbnZhbGlkPyBJZiB5ZXMsIHNob3VsZG4n dCB0aGUKPiBzdWJqZWN0IGFjdHVhbGx5IHNheSAiRml4IHZpcnR1YWwgc3RyaWRlIGNhbGN1bGF0 aW9uIj8KPgo+IEJlc3QgcmVnYXJkcywKPiBUb21hc3oKPgo+Cj4KSGkgVG9tYXN6CiAgICAgdGhl IGNhbGN1bGF0aW9uIHRoaW5raW5nIGJlZm9yZSBpcyB0aGF0OgogICAgICAgIGZiLT5waXRjaGVz WzBdID0gc3VyZmFjZV93aWR0aCAqIGJ5dGVzX3Blcl9waXhlbAogICAgICAgIHN1cmZhY2Vfd2lk dGggPSBmYi0+cGl0Y2hlc1swXSAvIGJ5dGVzX3Blcl9waXhlbAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgPSBmYi0+cGl0Y2hlc1swXSAvIChmYi0+Yml0c19wZXJfcGl4ZWwgPj4gMykK CiAgICBtZWFucyB0aGF0ICJ5X3Zpcl9zdHJpZGUgPSBzdXJmYWNlX3dpZHRoIiwKCkFSR0I4ODgg b25lIHBpeGVsIGlzIHdvcmQgc2l6ZSwgU28gdGhhdCBpcyByaWdodCBmb3IgQVJHQjg4OCwgYnV0 IHdyb25nIGZvciBvdGhlciBmb3JtYXRzLgoKWW91IGFyZSByaWdodCwgc3ViamVjdCBzYXkgIkZp eCB2aXJ0dWFsIHN0cmlkZSBjYWxjdWxhdGlvbiIgaXMgc3VpdGFibGUuCgpCZXN0IHJlZ2FyZHMs Ci0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Thu, 02 Jul 2015 14:13:11 +0800 Subject: [PATCH v2 1/5] drm/rockchip: vop: optimize virtual stride calculate In-Reply-To: References: <1435313249-4549-1-git-send-email-mark.yao@rock-chips.com> <1435313249-4549-2-git-send-email-mark.yao@rock-chips.com> Message-ID: <5594D677.20202@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?07?02? 12:59, Tomasz Figa wrote: > On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: >> vir_stride need number words of the virtual width, and fb->pitches >> save bytes_per_pixel, so just div 4 switch to stride. >> >> Signed-off-by: Mark Yao >> --- >> Changes in v2: None >> >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> index 6188221..3c9f4f3 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -644,7 +644,7 @@ static int vop_update_plane_event(struct drm_plane *plane, >> offset += (src.y1 >> 16) * fb->pitches[0]; >> yrgb_mst = rk_obj->dma_addr + offset; >> >> - y_vir_stride = fb->pitches[0] / (fb->bits_per_pixel >> 3); >> + y_vir_stride = fb->pitches[0] >> 2; > If the unit of y_vir_stride is words then doesn't it mean that the > calculation before this patch was just invalid? If yes, shouldn't the > subject actually say "Fix virtual stride calculation"? > > Best regards, > Tomasz > > > Hi Tomasz the calculation thinking before is that: fb->pitches[0] = surface_width * bytes_per_pixel surface_width = fb->pitches[0] / bytes_per_pixel = fb->pitches[0] / (fb->bits_per_pixel >> 3) means that "y_vir_stride = surface_width", ARGB888 one pixel is word size, So that is right for ARGB888, but wrong for other formats. You are right, subject say "Fix virtual stride calculation" is suitable. Best regards, -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812AbbGBGNd (ORCPT ); Thu, 2 Jul 2015 02:13:33 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:58080 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322AbbGBGNZ (ORCPT ); Thu, 2 Jul 2015 02:13:25 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: tfiga@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <7de987a06897cfaf2471e40cd70c02e6> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5594D677.20202@rock-chips.com> Date: Thu, 02 Jul 2015 14:13:11 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Tomasz Figa CC: dri-devel , David Airlie , Heiko Stuebner , Daniel Kurtz , Philipp Zabel , Daniel Vetter , Rob Clark , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" , sandy.huang@rock-chips.com, dkm@rock-chips.com, zwl@rock-chips.com, xw@rock-chips.com Subject: Re: [PATCH v2 1/5] drm/rockchip: vop: optimize virtual stride calculate References: <1435313249-4549-1-git-send-email-mark.yao@rock-chips.com> <1435313249-4549-2-git-send-email-mark.yao@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年07月02日 12:59, Tomasz Figa wrote: > On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: >> vir_stride need number words of the virtual width, and fb->pitches >> save bytes_per_pixel, so just div 4 switch to stride. >> >> Signed-off-by: Mark Yao >> --- >> Changes in v2: None >> >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> index 6188221..3c9f4f3 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -644,7 +644,7 @@ static int vop_update_plane_event(struct drm_plane *plane, >> offset += (src.y1 >> 16) * fb->pitches[0]; >> yrgb_mst = rk_obj->dma_addr + offset; >> >> - y_vir_stride = fb->pitches[0] / (fb->bits_per_pixel >> 3); >> + y_vir_stride = fb->pitches[0] >> 2; > If the unit of y_vir_stride is words then doesn't it mean that the > calculation before this patch was just invalid? If yes, shouldn't the > subject actually say "Fix virtual stride calculation"? > > Best regards, > Tomasz > > > Hi Tomasz the calculation thinking before is that: fb->pitches[0] = surface_width * bytes_per_pixel surface_width = fb->pitches[0] / bytes_per_pixel = fb->pitches[0] / (fb->bits_per_pixel >> 3) means that "y_vir_stride = surface_width", ARGB888 one pixel is word size, So that is right for ARGB888, but wrong for other formats. You are right, subject say "Fix virtual stride calculation" is suitable. Best regards, -- Ｍark Yao