All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Ian.Jackson" <Ian.Jackson@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] OSSTest: stop testing SEDF at all
Date: Thu, 2 Jul 2015 11:08:42 +0100	[thread overview]
Message-ID: <55950DAA.5070400@eu.citrix.com> (raw)
In-Reply-To: <1435685819.25170.318.camel@citrix.com>

On 06/30/2015 06:36 PM, Dario Faggioli wrote:
> SEDF has been broken and unmaintained at least
> until Xen 4.2, and most likely even before! Tests
> are failing without anyonce caring, and yet we're
> keeping using test resources for them.
> 
> Let's stop doing this!
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

> ---
> diff --git a/allow.all b/allow.all
> index 88a3038..8067d5e 100644
> --- a/allow.all
> +++ b/allow.all
> @@ -1,4 +1,3 @@
> -test-@@-sedf@@
>  test-@@-rtds@@
>  build-@@                        logs-capture@@
>  test-@@-pcipt@@
> diff --git a/make-flight b/make-flight
> index 31cb942..c763ce9 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -274,21 +274,6 @@ do_hvm_rhel6_tests () {
>    done
>  }
>  
> -do_sedf_tests () {
> -  if [ $xenarch != $dom0arch -o x$test_sedf != xy ]; then
> -    return
> -  fi
> -
> -  for pin in '' -pin; do
> -    job_create_test test-$xenarch$kern-$dom0arch-xl-sedf$pin  \
> -       test-debian xl $xenarch $dom0arch                      \
> -            guests_vcpus=4                                    \
> -            xen_boot_append="sched=sedf loglvl=all ${pin:+dom0_vcpus_pin}" \
> -            linux_boot_append='loglevel=9 debug'              \
> -            $debian_runvars all_hostflags=$most_hostflags
> -  done
> -}
> -
>  do_credit2_tests () {
>    if [ $xenarch != $dom0arch ]; then
>      return
> @@ -374,19 +359,18 @@ test_matrix_do_one () {
>  
>    do_multivcpu_tests
>  
> -  # RTDS came in 4.4, while SEDF is going away in 4.6
> +  # RTDS came in 4.5
>    case "$xenbranch" in
> -  xen-3.*-testing) test_sedf=y; test_rtds=n ;;
> -  xen-4.0-testing) test_sedf=y; test_rtds=n ;;
> -  xen-4.1-testing) test_sedf=y; test_rtds=n ;;
> -  xen-4.2-testing) test_sedf=y; test_rtds=n ;;
> -  xen-4.3-testing) test_sedf=y; test_rtds=n ;;
> -  xen-4.4-testing) test_sedf=y; test_rtds=n ;;
> -  xen-4.5-testing) test_sedf=y; test_rtds=y ;;
> -  *)               test_sedf=n; test_rtds=y ;;
> +  xen-3.*-testing) test_rtds=n ;;
> +  xen-4.0-testing) test_rtds=n ;;
> +  xen-4.1-testing) test_rtds=n ;;
> +  xen-4.2-testing) test_rtds=n ;;
> +  xen-4.3-testing) test_rtds=n ;;
> +  xen-4.4-testing) test_rtds=n ;;
> +  xen-4.5-testing) test_rtds=y ;;
> +  *)               test_rtds=y ;;
>    esac
>  
> -  do_sedf_tests
>    do_rtds_tests
>    do_credit2_tests
>  
> 

      parent reply	other threads:[~2015-07-02 10:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 17:36 [PATCH] OSSTest: stop testing SEDF at all Dario Faggioli
2015-06-30 17:50 ` Ian Jackson
2015-06-30 17:51 ` Dario Faggioli
2015-06-30 17:52   ` Ian Jackson
2015-07-02 10:08 ` George Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55950DAA.5070400@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.