Re: [PATCH 1/3] drm/exynos: remove to use ifdef CONFIG_ARM_DMA_USE_IOMMU

From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>,
	dri-devel@lists.freedesktop.org
Cc: sw0312.kim@samsung.com
Subject: Re: [PATCH 1/3] drm/exynos: remove to use ifdef CONFIG_ARM_DMA_USE_IOMMU
Date: Thu, 02 Jul 2015 16:00:09 +0200	[thread overview]
Message-ID: <559543E9.4070703@samsung.com> (raw)
In-Reply-To: <1435841379-28286-1-git-send-email-jy0922.shim@samsung.com>

Hello,

On 2015-07-02 14:49, Joonyoung Shim wrote:
> If CONFIG_ARM_DMA_USE_IOMMU is disable, CONFIG_DRM_EXYNOS_IOMMU also is
> disable. When CONFIG_DRM_EXYNOS_IOMMU is disable,
> is_drm_iommu_supported() returns always false, so we can remove to use
> ifdef CONFIG_ARM_DMA_USE_IOMMU in is_drm_iommu_supported().
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>   drivers/gpu/drm/exynos/exynos_drm_iommu.h | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.h b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> index 8341c7a..a90357f 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.h
> @@ -29,13 +29,9 @@ void drm_iommu_detach_device(struct drm_device *dev_dev,
>   
>   static inline bool is_drm_iommu_supported(struct drm_device *drm_dev)
>   {
> -#ifdef CONFIG_ARM_DMA_USE_IOMMU
>   	struct device *dev = drm_dev->dev;
>   
>   	return dev->archdata.mapping ? true : false;
> -#else
> -	return false;
> -#endif
>   }
>   
>   int drm_iommu_attach_device_if_possible(

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel