From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbbGBOEP (ORCPT ); Thu, 2 Jul 2015 10:04:15 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:35250 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbbGBOEG (ORCPT ); Thu, 2 Jul 2015 10:04:06 -0400 Message-ID: <559544D4.9010803@kernel.dk> Date: Thu, 02 Jul 2015 08:04:04 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jon Christopherson , Tejun Heo CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2 block/for-linus] writeback: don't drain bdi_writeback_congested on bdi destruction References: <20150702005253.GA26440@mtj.duckdns.org> <20150702005337.GB26440@mtj.duckdns.org> <5594A9B6.2050100@jons.org> In-Reply-To: <5594A9B6.2050100@jons.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2015 09:02 PM, Jon Christopherson wrote: > > > On 07/01/2015 07:53 PM, Tejun Heo wrote: >> 52ebea749aae ("writeback: make backing_dev_info host cgroup-specific >> bdi_writebacks") made bdi (backing_dev_info) host per-cgroup wb's >> (bdi_writeback's). As the congested state needs to be per-wb and >> referenced from blkcg side and multiple wbs, the patch made all >> non-root cong's (bdi_writeback_congested's) reference counted and >> indexed on bdi. >> > > > Thanks Tejun, > > I have applied your patches and no longer see the behavior > mentioned in the bug report. All is well! Tejun, I'll pick them up, and Jon, I'll add your tested-by to the commit. Thanks! -- Jens Axboe