From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753125AbbGBOUJ (ORCPT ); Thu, 2 Jul 2015 10:20:09 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:36748 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbbGBOUD (ORCPT ); Thu, 2 Jul 2015 10:20:03 -0400 Message-ID: <5595488F.6040906@kernel.dk> Date: Thu, 02 Jul 2015 08:19:59 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nicholas Krause CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] block:Fix various function return statements to comply with function's return type in blk-throttle.c References: <1435846384-25139-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1435846384-25139-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2015 08:13 AM, Nicholas Krause wrote: > This fixes various functions in the file blk-throttle.c with the > return type of bool to return true/false rather then one/zero > in order to better comply with these functions having a return > type of bool. Nicholas, stop sending me patches, I told you that last time too. I appreciate the effort, but there's always one or two errors in your patches. They are often not even compile tested, and definitely never runtime tested. Hence the risk/reward ratio just isn't great, and I don't want to apply them. Example from this patch: > @@ -855,7 +855,7 @@ static bool tg_with_in_iops_limit(struct throtl_grp *tg, struct bio *bio, > > if (wait) > *wait = jiffy_wait; > - return 0; > + return true; > } > > static bool tg_with_in_bps_limit(struct throtl_grp *tg, struct bio *bio, -- Jens Axboe