Re: [PATCH] mm:Make the function zap_huge_pmd bool

[nick <xerofoify@gmail.com>]

On 2015-07-02 12:03 PM, Theodore Ts'o wrote:
> On Thu, Jul 02, 2015 at 09:26:21AM +0200, Michal Hocko wrote:
>> On Wed 01-07-15 14:27:57, Nicholas Krause wrote:
>>> This makes the function zap_huge_pmd have a return type of bool
>>> now due to this particular function always returning one or zero
>>> as its return value.
>>
>> How does this help anything? IMO this just generates a pointless churn
>> in the code without a good reason.
> 
> Hi Michal,
> 
> My recommendation is to ignore patches sent by Nick.  In my experience
> he doesn't understand code before trying to make mechanical changes,
> and very few of his patches add any new value, and at least one that
> he tried to send me just 2 weeks or so ago (cherry-picked to try to
> "prove" why he had turned over a new leaf, so that I would support the
> removal of his e-mail address from being blacklisted on
> vger.kernel.org) was buggy, and when I asked him some basic questions
> about what the code was doing, it was clear he had no clue how the
> seq_file abstraction worked.  This didn't stop him from trying to
> patch the code, and if he had tested it, it would have crashed and
> burned instantly.
> 
> Of course, do whatevery you want, but IMHO it's not really not worth
> your time to deal with his patches, and if you reply, most people
> won't see his original e-mail since the vger.kernel.org blacklist is
> still in effect.
> 
> Regards,
> 
> 						- Ted
> 
Ted,
I looked into that patch further and would were correct it was wrong.
However here is a bug fix for the drm driver code that somebody else
stated was right but haven gotten a reply to from the maintainer and
have tried resending.
Nick