From mboxrd@z Thu Jan 1 00:00:00 1970 From: Terje Bergstrom Subject: Re: [PATCH] gpu: host1x: Fix MLOCK's debug info Date: Thu, 2 Jul 2015 14:15:01 -0700 Message-ID: <5595A9D5.5000209@nvidia.com> References: <1435519624-16444-1-git-send-email-digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1435519624-16444-1-git-send-email-digetx@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dmitry Osipenko , Thierry Reding Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-tegra@vger.kernel.org Ck9uIDA2LzI4LzIwMTUgMTI6MjcgUE0sIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiBNTE9DSydz IGRlYnVnIGluZm8sIHNwZXdlZCBvbiBDRE1BIHRpbWVvdXQsIGNvbnRhaW5zIG1lYW5pbmdsZXNz IE1MT0NLCj4gb3duZXIgY2hhbm5lbCBJRCBiZWNhdXNlIEhPU1QxWF9TWU5DX01MT0NLX09XTkVS X0NISURfRigpIHJldHVybnMgc2hpZnRlZAo+IHZhbHVlLCB3aGlsZSB1bnNoaWZ0ZWQgc2hvdWxk IGJlIHVzZWQuIEZpeCBpdCBieSBjaGFuZ2luZyAnX0YnIHRvICdfVicuCj4KPiBTaWduZWQtb2Zm LWJ5OiBEbWl0cnkgT3NpcGVua28gPGRpZ2V0eEBnbWFpbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJz L2dwdS9ob3N0MXgvaHcvZGVidWdfaHcuYyAgICAgICAgIHwgMiArLQo+ICAgZHJpdmVycy9ncHUv aG9zdDF4L2h3L2h3X2hvc3QxeDAxX3N5bmMuaCB8IDggKysrKy0tLS0KPiAgIGRyaXZlcnMvZ3B1 L2hvc3QxeC9ody9od19ob3N0MXgwMl9zeW5jLmggfCA4ICsrKystLS0tCj4gICBkcml2ZXJzL2dw dS9ob3N0MXgvaHcvaHdfaG9zdDF4MDRfc3luYy5oIHwgOCArKysrLS0tLQo+ICAgNCBmaWxlcyBj aGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9ob3N0MXgvaHcvZGVidWdfaHcuYyBiL2RyaXZlcnMvZ3B1L2hvc3QxeC9o dy9kZWJ1Z19ody5jCj4gaW5kZXggNzkxZGU5My4uY2MzZjE4MiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9ob3N0MXgvaHcvZGVidWdfaHcuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2hvc3QxeC9o dy9kZWJ1Z19ody5jCj4gQEAgLTI5OCw3ICsyOTgsNyBAQCBzdGF0aWMgdm9pZCBob3N0MXhfZGVi dWdfc2hvd19tbG9ja3Moc3RydWN0IGhvc3QxeCAqaG9zdCwgc3RydWN0IG91dHB1dCAqbykKPiAg IAkJCWhvc3QxeF9zeW5jX3JlYWRsKGhvc3QsIEhPU1QxWF9TWU5DX01MT0NLX09XTkVSKGkpKTsK PiAgIAkJaWYgKEhPU1QxWF9TWU5DX01MT0NLX09XTkVSX0NIX09XTlNfVihvd25lcikpCj4gICAJ CQlob3N0MXhfZGVidWdfb3V0cHV0KG8sICIlZDogbG9ja2VkIGJ5IGNoYW5uZWwgJWRcbiIsCj4g LQkJCQlpLCBIT1NUMVhfU1lOQ19NTE9DS19PV05FUl9DSElEX0Yob3duZXIpKTsKPiArCQkJCWks IEhPU1QxWF9TWU5DX01MT0NLX09XTkVSX0NISURfVihvd25lcikpOwo+ICAgCQllbHNlIGlmIChI T1NUMVhfU1lOQ19NTE9DS19PV05FUl9DUFVfT1dOU19WKG93bmVyKSkKPiAgIAkJCWhvc3QxeF9k ZWJ1Z19vdXRwdXQobywgIiVkOiBsb2NrZWQgYnkgY3B1XG4iLCBpKTsKPiAgIAkJZWxzZQooLi4u KQoKTG9va3MgZ29vZCwgYW5kIGZpeGVzIGEgYmFkIGdvdGNoYS4KClJldmlld2VkLUJ5OiBUZXJq ZSBCZXJnc3Ryb20gPHRiZXJnc3Ryb21AbnZpZGlhLmNvbT4KClRlcmplCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754320AbbGBVPP (ORCPT ); Thu, 2 Jul 2015 17:15:15 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:8516 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754176AbbGBVPK (ORCPT ); Thu, 2 Jul 2015 17:15:10 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 02 Jul 2015 14:15:10 -0700 Message-ID: <5595A9D5.5000209@nvidia.com> Date: Thu, 2 Jul 2015 14:15:01 -0700 From: Terje Bergstrom User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dmitry Osipenko , Thierry Reding CC: , , Subject: Re: [PATCH] gpu: host1x: Fix MLOCK's debug info References: <1435519624-16444-1-git-send-email-digetx@gmail.com> In-Reply-To: <1435519624-16444-1-git-send-email-digetx@gmail.com> X-Originating-IP: [172.17.184.28] X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/28/2015 12:27 PM, Dmitry Osipenko wrote: > MLOCK's debug info, spewed on CDMA timeout, contains meaningless MLOCK > owner channel ID because HOST1X_SYNC_MLOCK_OWNER_CHID_F() returns shifted > value, while unshifted should be used. Fix it by changing '_F' to '_V'. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/host1x/hw/debug_hw.c | 2 +- > drivers/gpu/host1x/hw/hw_host1x01_sync.h | 8 ++++---- > drivers/gpu/host1x/hw/hw_host1x02_sync.h | 8 ++++---- > drivers/gpu/host1x/hw/hw_host1x04_sync.h | 8 ++++---- > 4 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/host1x/hw/debug_hw.c b/drivers/gpu/host1x/hw/debug_hw.c > index 791de93..cc3f182 100644 > --- a/drivers/gpu/host1x/hw/debug_hw.c > +++ b/drivers/gpu/host1x/hw/debug_hw.c > @@ -298,7 +298,7 @@ static void host1x_debug_show_mlocks(struct host1x *host, struct output *o) > host1x_sync_readl(host, HOST1X_SYNC_MLOCK_OWNER(i)); > if (HOST1X_SYNC_MLOCK_OWNER_CH_OWNS_V(owner)) > host1x_debug_output(o, "%d: locked by channel %d\n", > - i, HOST1X_SYNC_MLOCK_OWNER_CHID_F(owner)); > + i, HOST1X_SYNC_MLOCK_OWNER_CHID_V(owner)); > else if (HOST1X_SYNC_MLOCK_OWNER_CPU_OWNS_V(owner)) > host1x_debug_output(o, "%d: locked by cpu\n", i); > else (...) Looks good, and fixes a bad gotcha. Reviewed-By: Terje Bergstrom Terje